Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nwjs v1.13.3 OS X Application name is always nwjs. #315

Closed
shripathee opened this issue Apr 28, 2016 · 6 comments
Closed

nwjs v1.13.3 OS X Application name is always nwjs. #315

shripathee opened this issue Apr 28, 2016 · 6 comments
Labels
bug Priority: 1 help-wanted
Milestone
2.2.2 - Editing e...

Comments

@shripathee
Copy link

Facing a weird issue where the application display name is always 'nwjs', irrespective of the name field in package.json and the appName in the nw-builder config. When I do 'Get Info' on the file, the given application name and extension are shown correctly, but in Finder it's always 'nwjs'.
@evshiron
Copy link

evshiron commented Apr 28, 2016 •
edited
Loading

See also #308.
Although the actual filename is appName.app, the display name is affected by both Info.plist and the i18n files located in /Contents/Resources/. In nw.js 0.12.x, there is no i18n files so altering Info.plist is enough, but it won't work after 0.13.x.
EDIT: rm -r appName.app/Contents/Resources/*.lproj should do the trick.

@sreuter
Copy link

sreuter commented Apr 29, 2016

@evshiron Name shows correctly then, but the app does crash and burn on startup then. [43609:1295:0429/124054:FATAL:chrome_browser_main_mac.mm(114)] Check failed: !loaded_locale.empty(). Default locale could not be found

yaroslav-n pushed a commit to atlassian/nw-builder that referenced this issue Apr 29, 2016
fix nwutils#315: macPlistStrings added to config
b50452c
@evshiron
Copy link

evshiron commented Apr 29, 2016 •
edited
Loading

@sreuter I have tried rm -r appName.app/Contents/Resources/*.lproj with 0.14.1-sdk, 0.14.2 and 0.15.0-beta1, all of them work and I can't reappear your result. Make sure you remove only *.lproj, and leave io.nwjs.nw.manifest unchanged.
More information is appreciated.

@sreuter
Copy link

sreuter commented Apr 29, 2016

@evshiron Thanks for the fast feedback. You are right, my grunt cleanup task was accidentally deleting
./io.nwjs.nw.manifest/Contents/Resources/en.lproj, too.

@evshiron
Copy link

@sreuter 🎉

@yaroslav-n yaroslav-n mentioned this issue Apr 29, 2016
Closed
flohdot pushed a commit to flohdot/nw-builder that referenced this issue May 30, 2016
@flohdot
fix nwutils#315: macPlistStrings added to config
a12eb03
@adam-lynch adam-lynch added the bug Priority: 1 label Jun 6, 2016
@adam-lynch
Copy link
Contributor

I think this might be resolved by #337 and version 2.2.1. Thanks!

MadLittleMods added a commit to gitterHQ/nw-builder that referenced this issue Jul 17, 2017
@MadLittleMods
Add option.winVersionString for accurate process name
11ac93b 
Fix nwutils#196
Fix nwutils#315

See

 - nwjs/nw.js#5809
 - nwjs/nw.js#5807
 - nwjs/nw.js#4293
 - nwjs/nw.js#2160
 - nwjs/nw.js#5829

Allows you to edit the version string of the resultant Windows executable.
These can be easily viewed in Properties -> Details, http://i.imgur.com/oqyRwaa.png

Fix issue where the process showed up as `nwjs` in Windows.
Now defaults to the `options.appName`
@MadLittleMods MadLittleMods mentioned this issue Jul 17, 2017
Merged
adam-lynch pushed a commit that referenced this issue Oct 19, 2017
@MadLittleMods @adam-lynch
Add option.winVersionString for accurate process name (#459)
748ff18 
Fix #196
Fix #315

See

 - nwjs/nw.js#5809
 - nwjs/nw.js#5807
 - nwjs/nw.js#4293
 - nwjs/nw.js#2160
 - nwjs/nw.js#5829

Allows you to edit the version string of the resultant Windows executable.
These can be easily viewed in Properties -> Details, http://i.imgur.com/oqyRwaa.png

Fix issue where the process showed up as `nwjs` in Windows.
Now defaults to the `options.appName`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Priority: 1 help-wanted
Projects
None yet
Milestone
2.2.2 - Editing executable information
Development

No branches or pull requests
4 participants
@sreuter @adam-lynch @shripathee @evshiron