Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils.copyFile not resolving with anything #181

Closed
chrisronline opened this issue Feb 4, 2015 · 6 comments
Closed

Utils.copyFile not resolving with anything #181

chrisronline opened this issue Feb 4, 2015 · 6 comments

Comments

@chrisronline
Copy link

Hi,

It looks like the copyFile method correctly resolves a promise when the copy is complete, but fails to pass in any useful data causing mergeAppFile to return an array of undefined which propagates to build and my calling code.

Path:
copyFile
mergeAppFiles
build

On this subject, ideally info contains information about the directory structure created and what files were created.

I can open a PR, but unsure your thoughts for this info variable.

Thanks

@adam-lynch
Copy link
Contributor

To be honest I'm not familiar with this. I wonder what this was doing originally. So what should info be in your opinion? An array of path strings?

@shennan
Copy link

shennan commented Feb 6, 2015

This sounds like it might be part of an issue I'm having. I get the following when building an OSX application on Windows:

Using cache for: osx32
Create release folder in C:\path\to\AppName\osx32
chmod 33206 on C:\path\to\AppName\osx32\AppName.app\Contents\Resources\nw.icns failed after copying, ignoring
{ [ Error: EPERM, operation not permitted 'C:\path\to\AppName\osx\AppName.app']
  errno: 50,
  code: 'EPERM',
  path: 'C:\\path\\to\\AppName\\osx32\\AppName.app',
  syscall: 'rename' }

The application bundles fine, but when it tries to do any of the icon stuff, it chokes with the above error. It's worth noting that the build sometimes succeeds, and sometimes fails. A fail is pretty inevitable when batch-building though.

Does this sound like it could be caused by this issue @chrisronline?

@adam-lynch
Copy link
Contributor

@shennan I don't see the connection, besides the fact that it involves copying too. I think you're having problems which we've been struggling with for a few versions now (look at other issues). Make sure you've the latest version, it's much better now but not 100% fixed.

@shennan
Copy link

shennan commented Feb 6, 2015

@adam-lynch You may be right. However, the other issues have not yet had the exact same error (EPERM 50). Also, what is strange is that it has only started failing in this way recently (within the last couple of days). I have been using latest webkit-node-builder, and have rolled back to 1.0.6 with the same result.

I just figured this might be related since the error is thrown round about this line in utils.js.

Which other issues do you think are relevant to this so I can have a good read and try and chip-in with a solution?

@adam-lynch
Copy link
Contributor

@shennan I'm thinking your problem is more to do with one of the following: #142 #144 #148 #170 #180

@chrisronline
Copy link
Author

I'm not sure @adam-lynch - I'm just hoping for some path information about where the built files live so I can use that in later build steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants