Skip to content

Escape double quotes in Windows options
Compare
Choose a tag to compare
@TheJaredWilcurt TheJaredWilcurt released this 17 Jun 13:50
· 21 commits to main since this release
v1.8.0
5375576
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Breaking Changes:

  • NONE! Your code should work exactly the same without changing anything.

Enhancements:

  • Windows arguments, comments, and hotkeys will now escape any double quotes (") passed in. This is because a VBScript is required on Windows to create shortcuts, and the VBS language uses the double quote as their escape key. This will fix issues like `arguments: '--thing="some text"' not working.
    • Special thanks to AngelCMHxD for reporting this issue.

Maintenance:

  • Updated dependencies
  • Wrote 3 new tests to ensure this bug fix remains fixed.

Code Quality:

  • Linting and Test coverage remains at 100%
  • E2E tests all passing
    • OSX at ~64-111ms
    • Windows at ~237-273ms
    • Linux at ~35-40ms

Code Changes

Assets 2
Loading