Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to node v16 #847

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Conversation

pm-pp
Copy link

@pm-pp pm-pp commented Oct 20, 2022

Hey 👋🏻

This action recently started to emit a warning about Node.js 12 actions being deprecated - GitHub Actions: All Actions will begin running on Node16 instead of Node12

This pull request's intention is to address the upgrade to node v16.

Great job with this action!

@arminrosu
Copy link

@nwtgck what do you think of this PR, is it merge-able?

@nwtgck
Copy link
Owner

nwtgck commented Nov 18, 2022

Good.

I have been preparing to update to Node16. All I have to do before the merge is to actually use the updated action to Node 16 to see if there are any problems. I also think about versioning because some actions did major updates after bumping up to Node 16.

@arminrosu
Copy link

I also think about versioning because some actions did major updates after bumping up to Node 16.

Most actions I use that got a major version bump used the node@16 deprecation opportunity to do some other work - like deprecating set::output, which required an upgrade of @actions/github to 5.* for them. e.g. aws-actions/configure-aws-credentials#521

IMO, that would conflate the node@16 upgrade for actions-netlify, though #829 would be nice for future proofing.


Thanks again for this action, made my life easier faster :)

@github-actions github-actions bot temporarily deployed to commit December 3, 2022 15:08 Inactive
@nwtgck
Copy link
Owner

nwtgck commented Dec 3, 2022

I'm testing this update now.

I'll write the log.

v1.2 log (I could not find deprecation warning...):
image

https://github.com/nwtgck/piping-ui-web/actions/runs/3609065235/jobs/6082034736

pm-pp-chore/node16-upgrade branch also works fine:
image
https://github.com/nwtgck/piping-ui-web/actions/runs/3609084576/jobs/6082063588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants