Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW.js throws error when zip file not present on every execution #7882

Closed
Sunvas opened this issue May 14, 2022 · 15 comments
Closed

NW.js throws error when zip file not present on every execution #7882

Sunvas opened this issue May 14, 2022 · 15 comments
Labels
has-min-repro Has a minimum reproduction nw2 regression

Comments

@Sunvas
Copy link

Sunvas commented May 14, 2022

NWJS Version : 0.64
Operating System : Windows 10

After closing program file debug.log is created alongside nw.exe with strange contents:

[0514/214309.922:ERROR:zip_reader.cc(132)] Cannot open ZIP from file handle 00000000000001A8
[0514/214309.922:ERROR:zip.cc(202)] Cannot open ZIP from file handle 00000000000001A
@jonlepage
Copy link
Contributor

ya , i also dont know what this is , its probably a old plugin or dependency not removed correcly in nwjs.
you can also see it in verbose mode
image

@sysrage
Copy link

sysrage commented May 16, 2022

@rogerwang I'm also getting this with all of my projects when using either 0.64.0 or 0.64.1 in either Windows 10 or Linux (Ubuntu 20.04). Can you please look into it?

@sysrage
Copy link

sysrage commented Jun 1, 2022

This is still an issue with version 0.65.0.

@jonlepage
Copy link
Contributor

it is can be related to this line?
Is the only trace of zip i can found

#include "third_party/zlib/google/zip.h"

am not experimented in C

@TheJaredWilcurt TheJaredWilcurt changed the title debug.log is always created NW.js throws error when zip file not present on every execution Jun 2, 2022
@sysrage
Copy link

sysrage commented Jun 11, 2022

This is still an issue with 0.65.1. I can confirm it happens in every OS.

@Sunvas
Copy link
Author

Sunvas commented Jun 22, 2022

live-build/nw66 - same issue

[0622/181233.966:ERROR:zip_reader.cc(153)] Cannot open ZIP from file handle 000000000000008C
[0622/181233.967:ERROR:zip.cc(202)] Cannot open ZIP from file handle 000000000000008C

@TheJaredWilcurt
Copy link
Member

@rogerwang This issue is still present

@TheJaredWilcurt TheJaredWilcurt added the has-min-repro Has a minimum reproduction label Jul 29, 2022
@lachezarR
Copy link

lachezarR commented Aug 2, 2022

This does not happen on 0.60.0 on my system but it happens with 0.66.1. What should I be looking for to fix this?

image

@sysrage
Copy link

sysrage commented Aug 2, 2022

This does happen with 0.66.0. It is not a configuration issue, it is a bug that @rogerwang will need to fix.

@lachezarR
Copy link

lachezarR commented Aug 2, 2022

This does happen with 0.66.0. It is not a configuration issue, it is a bug that @rogerwang will need to fix.

Sorry,
I meant 0.60.0. It's strange that the so called package.nw is not in /opt/nwjs folder for 0.60.0 as well, but it does not throw this error and build succeeds.

@Sunvas
Copy link
Author

Sunvas commented Aug 4, 2022

Same issue on 0.67, but debug.log is empty.

rogerwang added a commit that referenced this issue Aug 9, 2022
rogerwang added a commit to nwjs/chromium.src that referenced this issue Aug 9, 2022
@rogerwang
Copy link
Member

Fix released with 0.67.1

@JohnLego
Copy link

JohnLego commented Aug 11, 2022

Finally! It's been fixed!
Now this topic should be closed since the resolution came even though it should have 4 months ago.

@jonlepage
Copy link
Contributor

jonlepage commented Aug 11, 2022

Finally! It's been fixed! Now this topic should be closed since the resolution came even though it should have 4 months ago.

relax my friend!, he work alone and nw is free

@corwin-of-amber
Copy link
Contributor

Hello @rogerwang, thanks for the fix! Now I am not seeing the error about package.nw not existing, but I still get an error for app.nw:

Cannot open '/opt/homebrew/lib/node_modules/nw/nwjs/nwjs.app/Contents/Resources/app.nw': FILE_ERROR_NOT_FOUND: No such file or directory (2)

(installed via npm i -g over a Homebrew installation on macOS Monterey)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-min-repro Has a minimum reproduction nw2 regression
Projects
None yet
Development

No branches or pull requests

9 participants