Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parse): coerce version prerelease type to string #184

Merged
merged 2 commits into from
Jun 22, 2024
Merged

fix(parse): coerce version prerelease type to string #184

merged 2 commits into from
Jun 22, 2024

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Jun 22, 2024 •
edited
Loading

This PR fixes a type error.

TypeError: parsedVersion?.prerelease[0]?.endsWith is not a function
 ❯ parse node_modules/nw/src/parse.js:49:39
 ❯ Module.findpath node_modules/nw/src/util.js:51:15

@ayushmanchhabra ayushmanchhabra changed the title fixL coarce type to string fix: coerce type to string Jun 22, 2024
@ayushmanchhabra ayushmanchhabra changed the title fix: coerce type to string fix(parse): coerce type to string Jun 22, 2024
@ayushmanchhabra ayushmanchhabra changed the title fix(parse): coerce type to string fix(parse): coerce version prerelease type to string Jun 22, 2024
@ayushmanchhabra ayushmanchhabra merged commit 992aa86 into main Jun 22, 2024
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the type-error branch June 22, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ayushmanchhabra