-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESLint #105
Add ESLint #105
Conversation
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
extends: ['eslint:recommended'], | ||
rules: { | ||
quotes: ['error', 'single'], | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of stylistic rules that could be applied to make the code more consistent.
Here is my ruleset for reference:
Ones that come to mind when looking over this PR:
- Sometimes we add an extra comma at the end, sometimes we don't. Should probably add the
comma-dangle
rule to enforce that one way or the other. - Sometimes there is a space after a function name during a declaration, other times there is not.
space-before-function-paren
can enforce this, and the best rule would be to always have a space, so that the parenthesis only touch the name when the code is being executed to make a clear visual distinction.
Feel free to look through that ruleset and read the comments that explain what each rule does and port over whatever parts you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
I can open a new PR instead. There's no point in trying to revert changes made by Prettier. |
No description provided.