Skip to content

Commit

Permalink
refactor: use Array.prototype.join instead of $ operator
Browse files Browse the repository at this point in the history
Co-authored-by: The Jared Wilcurt <[email protected]>
  • Loading branch information
ayushmanchhabra and TheJaredWilcurt authored Oct 5, 2023
1 parent c8b4cab commit ed681cd
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/install.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ let buildType = env.npm_config_nwjs_build_type || env.NWJS_BUILD_TYPE || 'normal

// Parse Node manifest version.
let parsedVersion = semver.parse(nodeManifest.version);
let versionString = `${parsedVersion.major}.${parsedVersion.minor}.${parsedVersion.patch}`;
let versionString = [
parsedVersion.major,
parsedVersion.minor,
parsedVersion.patch
].join('.');

// Check if version is a prelease.
if (typeof parsedVersion?.prerelease?.[0] === 'string') {
Expand Down

0 comments on commit ed681cd

Please sign in to comment.