Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move v8_host_byteorder from Node to ICU #58

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Move v8_host_byteorder from Node to ICU #58

merged 1 commit into from
Dec 19, 2023

Conversation

ayushmanchhabra
Copy link
Contributor

@ayushmanchhabra ayushmanchhabra commented Nov 27, 2023

Description

Fixes: #46

Follow up of 0559697 which turned out to be an incorrect fix. Description of changes is in nwjs/nw.js#8145.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@ayushmanchhabra ayushmanchhabra changed the title Move v8_host_byteorder from Node to GYP Move v8_host_byteorder from Node to ICU Nov 28, 2023
@rogerwang rogerwang changed the base branch from nw82 to nw83 December 19, 2023 03:46
@rogerwang rogerwang merged commit 30c68ba into nwjs:nw83 Dec 19, 2023
@ayushmanchhabra ayushmanchhabra deleted the node-addon branch December 25, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "print sys.byteorder" (Python compatibility issue)
2 participants