Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all day events handling #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michael-maltsev
Copy link

All day event handling is broken. At least, Google Calendar on Android doesn't import it correctly. That's true for the following usage, which is given as an example in the readme:

cal.addEvent('Demo Event', 'This is an all day event', 'Nome, AK', '8/7/2013', '8/7/2013');

The current result is:

DTSTART;VALUE=DATE-TIME:20130807
DTEND;VALUE=DATE-TIME:20130807

According to this StackOverflow discussion, the correct result should be:

DTSTART;VALUE=DATE:20130807

i.e. a DATE instead of a DATE-TIME, and no DTEND if that's a single day. That's what this pull request does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant