Unlock src build for node version greater than 1.0 #1192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it doesn't have tests yet. |
|
This is blocked on #700 |
|
@ljharb the timeout issue, have you tried on other CI platform like circle ci? Maybe we don't need to close this one, just fix the problems here and then merge it. |
|
Either way, I wouldn't be able to merge this PR until I'd written tests that include building node from source. If circle-ci can run my tests from https://github.com/ljharb/nvm/tree/iojs_source - even if it's just the https://github.com/ljharb/nvm/tree/iojs_source/test/installation_iojs ones - without timing out, then it might be worth adding circle-ci just for the "from source" tests, which would then unblock me writing the same tests for node 4+. |
|
Obviated by #1204. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there any reason to "block" / "lock" the feature of building binary from source for nodejs version greater than v1.0? It could also help nvm work on FreeBSD since there is no official binary builds for FreeBSD from nodejs.org, and it actually work on by environment, just need more tests.
cc #900 #1188