Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ipynb #396

Merged
merged 2 commits into from
Feb 4, 2024
Merged

feat: add ipynb #396

merged 2 commits into from
Feb 4, 2024

Conversation

Rid1FZ
Copy link
Contributor

@Rid1FZ Rid1FZ commented Feb 2, 2024

No description provided.

@alex-courtis
Copy link
Member

Seti icon looks good.

There's are no icons defined for Jupyter; the notebook is very generic.

Could we simply use the python icon?

@Rid1FZ
Copy link
Contributor Author

Rid1FZ commented Feb 4, 2024 •
edited
Loading

@alex-courtis is it OK now? I kept the blue color to distinguish between normal python file and notebook.

alex-courtis
alex-courtis approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution!

@alex-courtis alex-courtis changed the title feat: added ipython notebook icon feat: add ipynb Feb 4, 2024
@alex-courtis alex-courtis merged commit 313d9e7 into nvim-tree:master Feb 4, 2024
5 checks passed
@Rid1FZ Rid1FZ deleted the notebook-icon branch February 5, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-courtis alex-courtis alex-courtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rid1FZ @alex-courtis