fix: add coq_nvim completion integration #1597
Conversation
TheLeoP
force-pushed
the
fix-coq-completion
branch
from
414f66d
to
f049952
Compare
| -- the following fields. Not all of them are used by Neorg, but | ||
| -- they are left here for future reference | ||
| local context = { | ||
| start_offset = nil, |
There was a problem hiding this comment.
What is the point of setting a key to nil here? In lua this is the same as not including the key at all
There was a problem hiding this comment.
I left them there for future reference.
As far as i can tell, there is no formal definition/interface for what the completion context should have. When i originally added support for coq, I missed a lot of fields (and the type inference of lua-ls didn't help (because of how the modules are structured, I think. I didn't look into it).
For this PR i had to look into both nvim-cmp and nvim-compe source code to know what fields a context is supposed to have and what the value of each one is supposed to be. Not all of the context's fields were currently being used by neorg, but since the current implementation seems tightly coupled with what nvim-compe consideres a context I thought leaving them here will help with future changes (removing the need to check nvim-compe and nvim-cmp codebases)
|
the heart reaction meant something like "great that someone is putting effort into this", i did not test this pull request (yet) |
Fixes #1594