Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): remove BufEnter event on linting #1200

Closed
wants to merge 1 commit into from

Conversation

rgruyters
Copy link
Contributor

When in use, linting will also be triggered when viewing lsp signature help (or lsp hover)

If you enter a hover- or signature help window, markdownlint triggers warninging within the LSP window. This is very annoying and shouldn't be triggered.

Here is a screenshot what happens when entering a LSP window.

image

When in use, linting will also be triggered when viewing lsp signature help
(or lsp hover)
@ccjmne
Copy link
Contributor

ccjmne commented Oct 20, 2024

Hmm, that's pretty smart. It's something that's been bothering me as well!
But then I suppose that you won't quite get diagnostics as you purposefully open a buffer whose linting you care for... Not until you enter and leave insert mode or write your buffer to a file, is that correct?

It may be better to identify somehow that the buffer you just entered is actually a pop-up one, and only disable these.

@ccjmne
Copy link
Contributor

ccjmne commented Oct 20, 2024

We could consider skipping the linting for read-only buffers. It works nicely, but may be undesirable in some cases.

@rgruyters
Copy link
Contributor Author

Hmm, that's pretty smart. It's something that's been bothering me as well! But then I suppose that you won't quite get diagnostics as you purposefully open a buffer whose linting you care for... Not until you enter and leave insert mode or write your buffer to a file, is that correct?

Yes that is correct.

It may be better to identify somehow that the buffer you just entered is actually a pop-up one, and only disable these.

That would be much better solution, but I didn't know how.

@rgruyters
Copy link
Contributor Author

I will close this PR, in favor for #1202

@rgruyters rgruyters closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants