Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set breakpoint icons and their highlight colors #1194

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

glmlm
Copy link
Contributor

@glmlm glmlm commented Oct 18, 2024

Set breakpoint icons and their highlight colors in lua/kickstart/plugins/debug.lua; see Here for details

@iton0
Copy link
Contributor

iton0 commented Oct 18, 2024

I think this should be a overall comment that users can uncomment if they want this change.

vim.api.nvim_set_hl(0, 'Break', { fg = '#e51400' })
vim.api.nvim_set_hl(0, 'Stop', { fg = '#ffcc00' })
local breakpoint_icons = vim.g.have_nerd_font
and { Breakpoint = '', BreakpointCondition = '', BreakpointRejected = '', LogPoint = '', Stopped = '' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it be better to just have one table of icons

Copy link
Contributor Author

@glmlm glmlm Oct 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing the code. With all due respect, that might not be possible.
If vim.g.have_nerd_font is false, the local variable breakpoint_icons would no longer exist.

Error that occurs when deleting the line:

Cannot assign `boolean|table` to parameter `<T:table>`.
   - `boolean` cannot match `table`
   - Type `boolean` cannot match `table` [param-type-mismatch]

feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so
@feoh
Copy link
Collaborator

feoh commented Oct 30, 2024

Hi guys I have no feelings on this.

@iton0 Can you help me understand why you think this should just be optional?

Do you use/do other people use different conditional break symbols?

@iton0
Copy link
Contributor

iton0 commented Oct 30, 2024

I appreciate the overall addition, but I wanted to make it optional for caution's sake. This way, users can experience the default debugging setup first and choose to add features if they wish, rather than having to remove anything.

@feoh
Copy link
Collaborator

feoh commented Oct 30, 2024

Ah I failed to notice it's already commented out. merging!

@feoh feoh merged commit be678aa into nvim-lua:master Oct 30, 2024
1 check passed
codemedic added a commit to codemedic/kickstart.nvim that referenced this pull request Oct 30, 2024
* master:
  Remove two because there are more than two. (nvim-lua#1213)
  Set breakpoint icons and their highlight colors (nvim-lua#1194)
  Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195)
  samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167)
  Disable linting autocmd for readonly buffers (nvim-lua#1202)
  fix: update lazy uninstall information link (nvim-lua#1148)
feoh pushed a commit to feoh/kickstart.nvim that referenced this pull request Oct 30, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
whalderman pushed a commit to whalderman/kickstart.nvim that referenced this pull request Nov 3, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
ginjiruu pushed a commit to ginjiruu/kickstart.nvim that referenced this pull request Nov 4, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
Livingpool pushed a commit to Livingpool/kickstart.nvim that referenced this pull request Nov 5, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
Murali1459 pushed a commit to Murali1459/drblue.nvim that referenced this pull request Nov 8, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
h4rldev pushed a commit to h4rldev/nvim that referenced this pull request Nov 8, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
ElMikosch pushed a commit to ElMikosch/nvim that referenced this pull request Nov 9, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
ge3224 pushed a commit to ge3224/nvimconf that referenced this pull request Nov 11, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
hojongs pushed a commit to hojongs/kickstart.nvim that referenced this pull request Nov 11, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
dartrix pushed a commit to dartrix/kickstart.nvim that referenced this pull request Nov 11, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
@glmlm glmlm deleted the breakpoint branch November 14, 2024 12:15
JordanSorensen6 pushed a commit to JordanSorensen6/kickstart.nvim that referenced this pull request Nov 14, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
aadi123 pushed a commit to aadi123/kickstart.nvim that referenced this pull request Nov 17, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
deepattic pushed a commit to deepattic/kickstart.nvim that referenced this pull request Nov 18, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
usainzg pushed a commit to usainzg/kickstart.nvim that referenced this pull request Nov 21, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
NgoranA pushed a commit to NgoranA/kickstart.nvim that referenced this pull request Nov 22, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
Peter-McKinney added a commit to Peter-McKinney/pete.nvim that referenced this pull request Nov 23, 2024
* Remove redundant hlsearch option (nvim-lua#1058)

* Modify conform comments to prevent deprecation warning when used (nvim-lua#1057)

* refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047)

* performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049)

* Remove treesitter prefer_git option (nvim-lua#1061)

- It's not safe and can corrupt other git repos
- nvim-treesiter maintainers consider `prefer_git` as deprecated and no
  longer needed.

See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959

* Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042)

* Update README.md (nvim-lua#1091)

* Add note in README about lazy-lock.json (nvim-lua#1090)

* Check for loop or uv for lazypath (nvim-lua#1095)

* refactor: update treesitter and which-key config (nvim-lua#1068)

* Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064)

* Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108)

* Fix: updated the windows installation commands (nvim-lua#1101)

* Update README.md

* Update README.md

* Fix: updated the windows installation commands

* fix: remove deprecated opt for conform.nvim (nvim-lua#1070)

- changed lsp_fallback -> lsp_format
- updated format_on_save function to reflect change above

* cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102)

- Moved `which-key` configuration from inline `config` to `opts` for better organization.
- Updated the key mappings setup to use `spec` for defining existing key chains.
- Removed deprecated or unnecessary comments and code.

This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068.

* Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113)

The recent cleanup accidentally broke the leader key specs
because the spec block was in the wrong level of braces.
That resulted in which-key no longer showing the description
of the <leader> key chains such as [S]earch and others.

* feat: update references of tsserver to ts_ls (nvim-lua#1131)

* fix: update lazy uninstall information link (nvim-lua#1148)

* Disable linting autocmd for readonly buffers (nvim-lua#1202)

* Disable linting autocmd for readonly buffers

This should avoid linting in buffers outside of the user's control,
having in mind especially the handy LSP pop-ups that describe your
hovered symbol using markdown.

Co-authored-by: Robin Gruyters <[email protected]>

* Justify guarding try_lint in readonly buffers

Co-authored-by: Robin Gruyters <[email protected]>

---------

Co-authored-by: Robin Gruyters <[email protected]>

* samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167)

* samarth-nagar fix: lazy help tag on line 931

found in issue nvim-lua#1152

* fixed white space

---------

Co-authored-by: sam <[email protected]>

* Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195)

* feat: Change diagnostic symbols if vim.g.have_nerd_font is true

* feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>

* Set breakpoint icons and their highlight colors (nvim-lua#1194)

* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>

* Remove two because there are more than two. (nvim-lua#1213)

* feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232)

* Fix nvim-dap not lazy loading (nvim-lua#1216)

* Fix nvim-dap not lazy loading

The keys property had local variables 'dap' and 'dap-ui' that used `require` and prevented all DAP related plugins from lazy-loading.
Fixed this by changing keys to a table and substituting the local variables with a lamba function

* Make debug keybind descriptions more consistent

* fix: which-key comment typo (nvim-lua#1227)

---------

Co-authored-by: Arvin Verain <[email protected]>
Co-authored-by: Brandon Clark <[email protected]>
Co-authored-by: Ihsan Tonuzi <[email protected]>
Co-authored-by: abeldekat <[email protected]>
Co-authored-by: jstrot <[email protected]>
Co-authored-by: theoboldalex <[email protected]>
Co-authored-by: Matt Gallagher <[email protected]>
Co-authored-by: Michael L. <[email protected]>
Co-authored-by: Bayram Kazik <[email protected]>
Co-authored-by: Harshit Pant <[email protected]>
Co-authored-by: Damjan 9000 <[email protected]>
Co-authored-by: Nicolás Baquero <[email protected]>
Co-authored-by: Bastien Traverse <[email protected]>
Co-authored-by: Éric NICOLAS <[email protected]>
Co-authored-by: Robin Gruyters <[email protected]>
Co-authored-by: sam <[email protected]>
Co-authored-by: sam <[email protected]>
Co-authored-by: gloomy-lemon-debatable <[email protected]>
Co-authored-by: Will Winder <[email protected]>
Co-authored-by: Anjishnu Banerjee <[email protected]>
Co-authored-by: Miha <[email protected]>
umairraza96 pushed a commit to umairraza96/kickstart.nvim that referenced this pull request Nov 26, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
BiboursMogz added a commit to BiboursMogz/kickstart-modular.nvim that referenced this pull request Dec 1, 2024
* which-key v3 update (nvim-lua#1022)

* which-key v3 update

* remove unneeded brackets from which-key registration

* fix(lazy): added error handling for bootstrap (nvim-lua#1001)

* fix: add required parsers from nvim-treesitter

* Fix neo-tree keymap description (nvim-lua#932)

The lazy.nvim keys parameter does not need the `desc` to
be inside a table in the way that vim.keymap.set() does.
With this fix the keymap description will be properly
shown for example in telescope keymap search

* Remove redundant require (nvim-lua#959)

* Make debug lazy loadable (nvim-lua#978)

* Update README.md | %userprofile%\appdata\local -> %localappdata% (nvim-lua#963)

- Replace `%userprofile%\AppData\Local\nvim\` and `$env:USERPROFILE\AppData\Local\nvim` to `%localappdata%\nvim` and `$env:LOCALAPPDATA\nvim respectfully`

* Make conform.nvim be lazy-loadable again (nvim-lua#977)

The PR that disabled lazy loading (nvim-lua#818) was to fix plugin not being
loaded before write. This sets up lazy to load conform before write.

* Fix comment about mini.ai example (nvim-lua#985)

This example wasn't using `'` so this makes more sense

* Neovim 0.10 updates (nvim-lua#936)

* Neovim 0.10 updates

Provide the buffer for which to enable inlay hints

Co-authored-by: Matt Mirus <[email protected]>

* refactor: replace vim.loop with vim.uv

* Upgrade folke/neodev (sunsetting) to folke/lazydev

* Update checkhealth for 0.10 release

---------

Co-authored-by: Matt Mirus <[email protected]>
Co-authored-by: mrr11k <[email protected]>
Co-authored-by: Seb Tomasini <[email protected]>

* Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040)

7513ec8 switched from neodev to
lazydev, but in the process it introduced an LSP error in `init.lua`,
which degrades the desired "first timer" experience of kickstart.nvim.

This commit follows the configuration suggested in
https://github.com/folke/lazydev.nvim/tree/6184ebbbc8045d70077659b7d30c705a588dc62f#-installation
which resolves the LSP error.

* lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947)

* fix: lsp warning

* review suggestion

Co-authored-by: Tom Kuson <[email protected]>

---------

Co-authored-by: Tom Kuson <[email protected]>

* Update comment about the toggle inlay hints keymap (nvim-lua#1041)

* Remove redundant hlsearch option (nvim-lua#1058)

* Modify conform comments to prevent deprecation warning when used (nvim-lua#1057)

* refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047)

* performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049)

* Remove treesitter prefer_git option (nvim-lua#1061)

- It's not safe and can corrupt other git repos
- nvim-treesiter maintainers consider `prefer_git` as deprecated and no
  longer needed.

See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959

* Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042)

* Update README.md (nvim-lua#1091)

* Add note in README about lazy-lock.json (nvim-lua#1090)

* Check for loop or uv for lazypath (nvim-lua#1095)

* refactor: update treesitter and which-key config (nvim-lua#1068)

* Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064)

* Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108)

* Fix: updated the windows installation commands (nvim-lua#1101)

* Update README.md

* Update README.md

* Fix: updated the windows installation commands

* fix: remove deprecated opt for conform.nvim (nvim-lua#1070)

- changed lsp_fallback -> lsp_format
- updated format_on_save function to reflect change above

* cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102)

- Moved `which-key` configuration from inline `config` to `opts` for better organization.
- Updated the key mappings setup to use `spec` for defining existing key chains.
- Removed deprecated or unnecessary comments and code.

This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068.

* Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113)

The recent cleanup accidentally broke the leader key specs
because the spec block was in the wrong level of braces.
That resulted in which-key no longer showing the description
of the <leader> key chains such as [S]earch and others.

* feat: update references of tsserver to ts_ls (nvim-lua#1131)

* fix: update lazy uninstall information link (nvim-lua#1148)

* Disable linting autocmd for readonly buffers (nvim-lua#1202)

* Disable linting autocmd for readonly buffers

This should avoid linting in buffers outside of the user's control,
having in mind especially the handy LSP pop-ups that describe your
hovered symbol using markdown.

Co-authored-by: Robin Gruyters <[email protected]>

* Justify guarding try_lint in readonly buffers

Co-authored-by: Robin Gruyters <[email protected]>

---------

Co-authored-by: Robin Gruyters <[email protected]>

* samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167)

* samarth-nagar fix: lazy help tag on line 931

found in issue nvim-lua#1152

* fixed white space

---------

Co-authored-by: sam <[email protected]>

* Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195)

* feat: Change diagnostic symbols if vim.g.have_nerd_font is true

* feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>

* Set breakpoint icons and their highlight colors (nvim-lua#1194)

* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>

* Remove two because there are more than two. (nvim-lua#1213)

* feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232)

* Fix nvim-dap not lazy loading (nvim-lua#1216)

* Fix nvim-dap not lazy loading

The keys property had local variables 'dap' and 'dap-ui' that used `require` and prevented all DAP related plugins from lazy-loading.
Fixed this by changing keys to a table and substituting the local variables with a lamba function

* Make debug keybind descriptions more consistent

* fix: which-key comment typo (nvim-lua#1227)

---------

Co-authored-by: Vladislav Grechannik <[email protected]>
Co-authored-by: Folke Lemaitre <[email protected]>
Co-authored-by: Damjan 9000 <[email protected]>
Co-authored-by: TJ DeVries <[email protected]>
Co-authored-by: Tom Kuson <[email protected]>
Co-authored-by: Artyom <[email protected]>
Co-authored-by: Richard Macklin <[email protected]>
Co-authored-by: Matt Mirus <[email protected]>
Co-authored-by: mrr11k <[email protected]>
Co-authored-by: Seb Tomasini <[email protected]>
Co-authored-by: srdtrk <[email protected]>
Co-authored-by: Arvin Verain <[email protected]>
Co-authored-by: Brandon Clark <[email protected]>
Co-authored-by: Ihsan Tonuzi <[email protected]>
Co-authored-by: abeldekat <[email protected]>
Co-authored-by: jstrot <[email protected]>
Co-authored-by: theoboldalex <[email protected]>
Co-authored-by: Matt Gallagher <[email protected]>
Co-authored-by: Michael L. <[email protected]>
Co-authored-by: Bayram Kazik <[email protected]>
Co-authored-by: Harshit Pant <[email protected]>
Co-authored-by: Nicolás Baquero <[email protected]>
Co-authored-by: Bastien Traverse <[email protected]>
Co-authored-by: Éric NICOLAS <[email protected]>
Co-authored-by: Robin Gruyters <[email protected]>
Co-authored-by: sam <[email protected]>
Co-authored-by: sam <[email protected]>
Co-authored-by: gloomy-lemon-debatable <[email protected]>
Co-authored-by: Will Winder <[email protected]>
Co-authored-by: Anjishnu Banerjee <[email protected]>
Co-authored-by: Miha <[email protected]>
Co-authored-by: mogz <[email protected]>
gcaufield added a commit to gcaufield/kickstart.nvim that referenced this pull request Dec 3, 2024
* upstream/master: (39 commits)
  fix: which-key comment typo (nvim-lua#1227)
  Fix nvim-dap not lazy loading (nvim-lua#1216)
  feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232)
  Remove two because there are more than two. (nvim-lua#1213)
  Set breakpoint icons and their highlight colors (nvim-lua#1194)
  Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195)
  samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167)
  Disable linting autocmd for readonly buffers (nvim-lua#1202)
  fix: update lazy uninstall information link (nvim-lua#1148)
  feat: update references of tsserver to ts_ls (nvim-lua#1131)
  Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113)
  cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102)
  fix: remove deprecated opt for conform.nvim (nvim-lua#1070)
  Fix: updated the windows installation commands (nvim-lua#1101)
  Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108)
  Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064)
  refactor: update treesitter and which-key config (nvim-lua#1068)
  Check for loop or uv for lazypath (nvim-lua#1095)
  Add note in README about lazy-lock.json (nvim-lua#1090)
  Update README.md (nvim-lua#1091)
  Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042)
  Remove treesitter prefer_git option (nvim-lua#1061)
  performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049)
  refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047)
  Modify conform comments to prevent deprecation warning when used (nvim-lua#1057)
  Remove redundant hlsearch option (nvim-lua#1058)
  Update comment about the toggle inlay hints keymap (nvim-lua#1041)
  lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947)
  Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040)
  Neovim 0.10 updates (nvim-lua#936)
  ...
gotocoffee1 pushed a commit to gotocoffee1/kickstart.nvim that referenced this pull request Dec 9, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
rrcomtech pushed a commit to rrcomtech/neovim-config that referenced this pull request Dec 11, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
dipzera pushed a commit to dipzera/kickstart.nvim that referenced this pull request Dec 18, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
sychugin pushed a commit to sychugin/kickstart.nvim that referenced this pull request Dec 19, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
vivek-shrikhande pushed a commit to vivek-shrikhande/kickstart.nvim that referenced this pull request Dec 19, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
sychugin pushed a commit to sychugin/kickstart.nvim that referenced this pull request Dec 19, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
ramintheredmn pushed a commit to ramintheredmn/myneovim.nvim that referenced this pull request Dec 21, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
fardente pushed a commit to fardente/kickstart.nvim that referenced this pull request Dec 26, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
NathanKuhn pushed a commit to NathanKuhn/kickstart.nvim that referenced this pull request Dec 27, 2024
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
kontr0x pushed a commit to kontr0x/my-kickstart.nvim that referenced this pull request Jan 2, 2025
* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>
BiboursMogz added a commit to BiboursMogz/kickstart-modular.nvim that referenced this pull request Jan 2, 2025
* which-key v3 update (nvim-lua#1022)

* which-key v3 update

* remove unneeded brackets from which-key registration

* fix(lazy): added error handling for bootstrap (nvim-lua#1001)

* fix: add required parsers from nvim-treesitter

* Fix neo-tree keymap description (nvim-lua#932)

The lazy.nvim keys parameter does not need the `desc` to
be inside a table in the way that vim.keymap.set() does.
With this fix the keymap description will be properly
shown for example in telescope keymap search

* Remove redundant require (nvim-lua#959)

* Make debug lazy loadable (nvim-lua#978)

* Update README.md | %userprofile%\appdata\local -> %localappdata% (nvim-lua#963)

- Replace `%userprofile%\AppData\Local\nvim\` and `$env:USERPROFILE\AppData\Local\nvim` to `%localappdata%\nvim` and `$env:LOCALAPPDATA\nvim respectfully`

* Make conform.nvim be lazy-loadable again (nvim-lua#977)

The PR that disabled lazy loading (nvim-lua#818) was to fix plugin not being
loaded before write. This sets up lazy to load conform before write.

* Fix comment about mini.ai example (nvim-lua#985)

This example wasn't using `'` so this makes more sense

* Neovim 0.10 updates (nvim-lua#936)

* Neovim 0.10 updates

Provide the buffer for which to enable inlay hints

Co-authored-by: Matt Mirus <[email protected]>

* refactor: replace vim.loop with vim.uv

* Upgrade folke/neodev (sunsetting) to folke/lazydev

* Update checkhealth for 0.10 release

---------

Co-authored-by: Matt Mirus <[email protected]>
Co-authored-by: mrr11k <[email protected]>
Co-authored-by: Seb Tomasini <[email protected]>

* Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040)

7513ec8 switched from neodev to
lazydev, but in the process it introduced an LSP error in `init.lua`,
which degrades the desired "first timer" experience of kickstart.nvim.

This commit follows the configuration suggested in
https://github.com/folke/lazydev.nvim/tree/6184ebbbc8045d70077659b7d30c705a588dc62f#-installation
which resolves the LSP error.

* lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947)

* fix: lsp warning

* review suggestion

Co-authored-by: Tom Kuson <[email protected]>

---------

Co-authored-by: Tom Kuson <[email protected]>

* Update comment about the toggle inlay hints keymap (nvim-lua#1041)

* Remove redundant hlsearch option (nvim-lua#1058)

* Modify conform comments to prevent deprecation warning when used (nvim-lua#1057)

* refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047)

* performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049)

* Remove treesitter prefer_git option (nvim-lua#1061)

- It's not safe and can corrupt other git repos
- nvim-treesiter maintainers consider `prefer_git` as deprecated and no
  longer needed.

See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959

* Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042)

* Update README.md (nvim-lua#1091)

* Add note in README about lazy-lock.json (nvim-lua#1090)

* Check for loop or uv for lazypath (nvim-lua#1095)

* refactor: update treesitter and which-key config (nvim-lua#1068)

* Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064)

* Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108)

* Fix: updated the windows installation commands (nvim-lua#1101)

* Update README.md

* Update README.md

* Fix: updated the windows installation commands

* fix: remove deprecated opt for conform.nvim (nvim-lua#1070)

- changed lsp_fallback -> lsp_format
- updated format_on_save function to reflect change above

* cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102)

- Moved `which-key` configuration from inline `config` to `opts` for better organization.
- Updated the key mappings setup to use `spec` for defining existing key chains.
- Removed deprecated or unnecessary comments and code.

This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068.

* Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113)

The recent cleanup accidentally broke the leader key specs
because the spec block was in the wrong level of braces.
That resulted in which-key no longer showing the description
of the <leader> key chains such as [S]earch and others.

* feat: update references of tsserver to ts_ls (nvim-lua#1131)

* fix: update lazy uninstall information link (nvim-lua#1148)

* Disable linting autocmd for readonly buffers (nvim-lua#1202)

* Disable linting autocmd for readonly buffers

This should avoid linting in buffers outside of the user's control,
having in mind especially the handy LSP pop-ups that describe your
hovered symbol using markdown.

Co-authored-by: Robin Gruyters <[email protected]>

* Justify guarding try_lint in readonly buffers

Co-authored-by: Robin Gruyters <[email protected]>

---------

Co-authored-by: Robin Gruyters <[email protected]>

* samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167)

* samarth-nagar fix: lazy help tag on line 931

found in issue nvim-lua#1152

* fixed white space

---------

Co-authored-by: sam <[email protected]>

* Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195)

* feat: Change diagnostic symbols if vim.g.have_nerd_font is true

* feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>

* Set breakpoint icons and their highlight colors (nvim-lua#1194)

* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>

* Remove two because there are more than two. (nvim-lua#1213)

* feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232)

* Fix nvim-dap not lazy loading (nvim-lua#1216)

* Fix nvim-dap not lazy loading

The keys property had local variables 'dap' and 'dap-ui' that used `require` and prevented all DAP related plugins from lazy-loading.
Fixed this by changing keys to a table and substituting the local variables with a lamba function

* Make debug keybind descriptions more consistent

* fix: which-key comment typo (nvim-lua#1227)

---------

Co-authored-by: Vladislav Grechannik <[email protected]>
Co-authored-by: Folke Lemaitre <[email protected]>
Co-authored-by: Damjan 9000 <[email protected]>
Co-authored-by: TJ DeVries <[email protected]>
Co-authored-by: Tom Kuson <[email protected]>
Co-authored-by: Artyom <[email protected]>
Co-authored-by: Richard Macklin <[email protected]>
Co-authored-by: Matt Mirus <[email protected]>
Co-authored-by: mrr11k <[email protected]>
Co-authored-by: Seb Tomasini <[email protected]>
Co-authored-by: srdtrk <[email protected]>
Co-authored-by: Arvin Verain <[email protected]>
Co-authored-by: Brandon Clark <[email protected]>
Co-authored-by: Ihsan Tonuzi <[email protected]>
Co-authored-by: abeldekat <[email protected]>
Co-authored-by: jstrot <[email protected]>
Co-authored-by: theoboldalex <[email protected]>
Co-authored-by: Matt Gallagher <[email protected]>
Co-authored-by: Michael L. <[email protected]>
Co-authored-by: Bayram Kazik <[email protected]>
Co-authored-by: Harshit Pant <[email protected]>
Co-authored-by: Nicolás Baquero <[email protected]>
Co-authored-by: Bastien Traverse <[email protected]>
Co-authored-by: Éric NICOLAS <[email protected]>
Co-authored-by: Robin Gruyters <[email protected]>
Co-authored-by: sam <[email protected]>
Co-authored-by: sam <[email protected]>
Co-authored-by: gloomy-lemon-debatable <[email protected]>
Co-authored-by: Will Winder <[email protected]>
Co-authored-by: Anjishnu Banerjee <[email protected]>
Co-authored-by: Miha <[email protected]>
Co-authored-by: mogz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants