Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kickstart checkhealth reports version as table: 0x7f01f79278d8 #677

Closed
dam9000 opened this issue Mar 3, 2024 · 0 comments · Fixed by #685
Closed

kickstart checkhealth reports version as table: 0x7f01f79278d8 #677

dam9000 opened this issue Mar 3, 2024 · 0 comments · Fixed by #685

Comments

@dam9000
Copy link
Contributor

dam9000 commented Mar 3, 2024

Running :checkhealth reports the version as a table: 0x7f01f79278d8 instead of an actual version string:

kickstart: require("kickstart.health").check()
kickstart.nvim ~
...
- OK Neovim version is: 'table: 0x7f01f79278d8'

If I call:

:lua vim.print(vim.version())

it will print the following:

{
  api_compatible = 0,
  api_level = 11,
  api_prerelease = false,
  major = 0,
  minor = 9,
  patch = 5,
  prerelease = false
}

Seems there is an issue with tostring(), this prints table:

:lua print(tostring(vim.version())
table: 0x7f01f79278d8

After some more testing it seems that the tostring(vim.version()) works starting with nvim 0.10.0, but since kickstart considers 0.9.4 version as recent enough and the message for old version also uses tostring() I'd say this needs to be fixed.

dam9000 added a commit to dam9000/kickstart-modular.nvim that referenced this issue Mar 3, 2024
Fixes: nvim-lua#677
Neovim prior to 0.10 does not support tostring(vim.version())
this resulted in the :checkhealth reported version as:
- OK Neovim version is: 'table: 0x7f470b340028'
With this fix the version is reported properly:
- OK Neovim version is: '0.9.5'
@feoh feoh closed this as completed in #685 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant