Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Return of "cannot find package bash-debug-adapter" #554

Closed
johnpekcan opened this issue Dec 23, 2023 · 3 comments
Closed

The Return of "cannot find package bash-debug-adapter" #554

johnpekcan opened this issue Dec 23, 2023 · 3 comments

Comments

@johnpekcan
Copy link
Contributor

Describe the bug

I believe we have a regression of a bug fix 😅
The fix here: de1db70
Was removed recently: 6ffc5a1

[ERROR Sat Dec 23 09:37:46 2023] ...l/share/nvim/lazy/mason.nvim/lua/mason-registry/init.lua:79: Cannot find package "\"bash-debug-adapter\"".

To Reproduce

  1. git clone per read me.
  2. uncomment require 'kickstart.plugins.debug'
  3. Look at :MasonLog
  4. fwiw repro also works in https://github.com/dam9000/kickstart-modular.nvim (I can open a separate issue there)

Desktop

  • OS: 23.2.0 Darwin Kernel Version 23.2.0: root:xnu-10002.61.3~2/RELEASE_ARM64_T6020 arm64
  • Terminal: zsh 5.9 (x86_64-apple-darwin23.0)

Neovim Version

NVIM v0.9.4
Build type: Release
LuaJIT 2.1.1700008891

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/opt/homebrew/Cellar/neovim/0.9.4/share/nvim"
@feoh
Copy link
Collaborator

feoh commented Dec 23, 2023

Thanks for the repott! Care to file a PR to fix this?

@johnpekcan johnpekcan mentioned this issue Dec 24, 2023
Merged
@johnpekcan
Copy link
Contributor Author

Cheers @feoh , I've submitted a PR to restore that line.

@johnpekcan johnpekcan mentioned this issue Dec 24, 2023
Closed
@feoh
Copy link
Collaborator

feoh commented Dec 24, 2023

Thanks very much for the fix! Really appreciate the contribution!

@GameFuzzy GameFuzzy mentioned this issue Apr 19, 2024
Merged
smrznuti1 pushed a commit to smrznuti1/nvc that referenced this issue Dec 17, 2024
@stevearc
fix: crash in error handling for function formatters (nvim-lua#554)
51e99ef
smrznuti1 pushed a commit to smrznuti1/nvc that referenced this issue Dec 17, 2024
@stevearc @F1lipB
fix: crash in error handling for function formatters (nvim-lua#554)
a4d9ca3
@tomasgareau tomasgareau mentioned this issue Jan 3, 2025
Closed
tomasgareau added a commit to tomasgareau/kickstart.nvim that referenced this issue Jan 3, 2025
@tomasgareau
fix: prevent mason setup from being run twice
95daefb 
Addresses nvim-lua#1297

Currently, we're calling `require('mason').setup(...)` twice:
* once when setting it as a dependency of `nvim-lspconfig` (since we set
	`config = true`)
* once in the `config` function we define for `nvim-lspconfig`

Calling setup twice can cause issues with, e.g., setting the `PATH`
option: you might append Mason's bin dir in one setup call and prepend
it in the other.

We've kept the setup of `mason` in the `nvim-lspconfig` dependencies
table since leaving it to the `config` function caused some
plugin-loading-order related issues in the past. See:
* nvim-lua#210
* nvim-lua#554
* nvim-lua#555
* nvim-lua#865
@tomasgareau tomasgareau mentioned this issue Jan 3, 2025
Merged
feoh pushed a commit that referenced this issue Jan 7, 2025
@tomasgareau
fix: prevent mason setup from being run twice (#1298)
db4867a 
* fix: prevent mason setup from being run twice

Addresses #1297

Currently, we're calling `require('mason').setup(...)` twice:
* once when setting it as a dependency of `nvim-lspconfig` (since we set
	`config = true`)
* once in the `config` function we define for `nvim-lspconfig`

Calling setup twice can cause issues with, e.g., setting the `PATH`
option: you might append Mason's bin dir in one setup call and prepend
it in the other.

We've kept the setup of `mason` in the `nvim-lspconfig` dependencies
table since leaving it to the `config` function caused some
plugin-loading-order related issues in the past. See:
* #210
* #554
* #555
* #865

* docs: tweak comments per review feedback
@biofilos biofilos mentioned this issue Jan 7, 2025
Merged
dribic pushed a commit to dribic/nvim-files that referenced this issue Jan 8, 2025
@tomasgareau @dribic
fix: prevent mason setup from being run twice (nvim-lua#1298)
bcc3820 
* fix: prevent mason setup from being run twice

Addresses nvim-lua#1297

Currently, we're calling `require('mason').setup(...)` twice:
* once when setting it as a dependency of `nvim-lspconfig` (since we set
	`config = true`)
* once in the `config` function we define for `nvim-lspconfig`

Calling setup twice can cause issues with, e.g., setting the `PATH`
option: you might append Mason's bin dir in one setup call and prepend
it in the other.

We've kept the setup of `mason` in the `nvim-lspconfig` dependencies
table since leaving it to the `config` function caused some
plugin-loading-order related issues in the past. See:
* nvim-lua#210
* nvim-lua#554
* nvim-lua#555
* nvim-lua#865

* docs: tweak comments per review feedback

Signed-off-by: Dejan Ribič <[email protected]>
Mutex- pushed a commit to Mutex-/kickstart.nvim that referenced this issue Jan 8, 2025
@tomasgareau @Mutex-
fix: prevent mason setup from being run twice (nvim-lua#1298)
44f7837 
* fix: prevent mason setup from being run twice

Addresses nvim-lua#1297

Currently, we're calling `require('mason').setup(...)` twice:
* once when setting it as a dependency of `nvim-lspconfig` (since we set
	`config = true`)
* once in the `config` function we define for `nvim-lspconfig`

Calling setup twice can cause issues with, e.g., setting the `PATH`
option: you might append Mason's bin dir in one setup call and prepend
it in the other.

We've kept the setup of `mason` in the `nvim-lspconfig` dependencies
table since leaving it to the `config` function caused some
plugin-loading-order related issues in the past. See:
* nvim-lua#210
* nvim-lua#554
* nvim-lua#555
* nvim-lua#865

* docs: tweak comments per review feedback
ppizarro pushed a commit to ppizarro/my.vim that referenced this issue Jan 8, 2025
@paulopizarro
fix: prevent mason setup from being run twice (#1298)
80bc39f 
* fix: prevent mason setup from being run twice

Addresses nvim-lua/kickstart.nvim#1297

Currently, we're calling `require('mason').setup(...)` twice:
* once when setting it as a dependency of `nvim-lspconfig` (since we set
        `config = true`)
* once in the `config` function we define for `nvim-lspconfig`

Calling setup twice can cause issues with, e.g., setting the `PATH`
option: you might append Mason's bin dir in one setup call and prepend
it in the other.

We've kept the setup of `mason` in the `nvim-lspconfig` dependencies
table since leaving it to the `config` function caused some
plugin-loading-order related issues in the past. See:
* nvim-lua/kickstart.nvim#210
* nvim-lua/kickstart.nvim#554
* nvim-lua/kickstart.nvim#555
* nvim-lua/kickstart.nvim#865

* docs: tweak comments per review feedback
@MasterUgwae MasterUgwae mentioned this issue Jan 8, 2025
Open
@BasedScott BasedScott mentioned this issue Jan 9, 2025
Merged
@umtdg umtdg mentioned this issue Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feoh @johnpekcan