New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The comments of the configuration of which-key are outdated #1249

Closed

LorenzoBettini opened this issue Dec 2, 2024 · 0 comments · Fixed by #1250 or #1263

LorenzoBettini commented Dec 2, 2024

Describe the bug

The documentation of the configuration of which-key are outdated since it mentions the config method (as in the video https://www.youtube.com/watch?v=m8C0Cq9Uv9o) but they are now based on opts:

  -- Then, because we use the `config` key, the configuration only runs
  -- after the plugin has been loaded:
  --  config = function() ... end
...
  { -- Useful plugin to show you pending keybinds.
    'folke/which-key.nvim',
    event = 'VimEnter', -- Sets the loading event to 'VimEnter'
    opts = {
      icons = {

To Reproduce

...

Desktop

OS:
Terminal:

Neovim Version

The text was updated successfully, but these errors were encountered:

benfleis added a commit to benfleis/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage.

45ff388

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

benfleis mentioned this issue

Tweak outdated comment about lazy's config key usage. #1250

Merged

feoh closed this as completed in #1250

feoh pushed a commit that referenced this issue


          Tweak outdated comment about lazy's config key usage. (#1250)

7bc9d19

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes #1249

benfleis mentioned this issue

Issue 1249 which key comments #1263

Merged

feoh pushed a commit that referenced this issue


          Issue 1249 which key comments (#1263)

bcdb4cd

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes #1249

* fix typo opt -> opts

Fixes #1250

NgoranA pushed a commit to NgoranA/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

2de145e

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

NgoranA pushed a commit to NgoranA/kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

4b96522

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

melito00 pushed a commit to melito00/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

3ccc6b5

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

melito00 pushed a commit to melito00/kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

dipzera pushed a commit to dipzera/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

a71b84d

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

dipzera pushed a commit to dipzera/kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

43292d1

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

sychugin pushed a commit to sychugin/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

be65277

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

sychugin pushed a commit to sychugin/kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

ad861d4

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

vivek-shrikhande pushed a commit to vivek-shrikhande/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

97c9e78

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

vivek-shrikhande pushed a commit to vivek-shrikhande/kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

001cd0d

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

sychugin pushed a commit to sychugin/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

6a10252

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

sychugin pushed a commit to sychugin/kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

3226faa

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

ramintheredmn pushed a commit to ramintheredmn/myneovim.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

ae9b9a0

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

ramintheredmn pushed a commit to ramintheredmn/myneovim.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

samiiali pushed a commit to samiiali/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

f9f3b67

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

samiiali pushed a commit to samiiali/kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

273feb9

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

fardente pushed a commit to fardente/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

79e71c5

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

fardente pushed a commit to fardente/kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

c86de55

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

NathanKuhn pushed a commit to NathanKuhn/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

fc0e3fd

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

NathanKuhn pushed a commit to NathanKuhn/kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

4d94fb3

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

gant123 pushed a commit to gant123/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

7bbb6bb

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

gant123 pushed a commit to gant123/kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

04a3784

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

kontr0x pushed a commit to kontr0x/my-kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

kontr0x pushed a commit to kontr0x/my-kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

945eedc

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

RockBacon9922 pushed a commit to RockBacon9922/nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

3a9c7c6

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

RockBacon9922 pushed a commit to RockBacon9922/nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

820d98a

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

mhamza15 pushed a commit to mhamza15/kickstart.nvim that referenced this issue


          Tweak outdated comment about lazy's config key usage. (nvim-lua#1250)

1de7aea

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

mhamza15 pushed a commit to mhamza15/kickstart.nvim that referenced this issue


          Issue 1249 which key comments (nvim-lua#1263)

65ff3e8

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment