fix: Check for None type custom dict #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomer-nvidia
previously approved these changes
Nov 29, 2024
|
Changed the target. It should be targeted to release/2.18.0. |
atomer-nvidia
approved these changes
Nov 29, 2024
rmittal-github
pushed a commit
that referenced
this pull request
Dec 13, 2024
* fix: Check for None type custom dict (#106) fix: Check for None type custom dict * Add DNT and custom translation support in NMT client (#108) * changes made for custom translation, dnt phrases * formatted * minor fixes done * changes made * minor fix done * changes done * changes made * changes made for dnt and custom translation * .gitmodules changed --------- Co-authored-by: Manisha Johnson <[email protected]> * fix: undeclared variable (#109) * Updating git SHA to point to TOT main * Updating git SHA to point to TOT main --------- Co-authored-by: mohnishparmar <[email protected]> Co-authored-by: ydharavath <[email protected]> Co-authored-by: Manisha Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks for default empty dict and skip iterating over none