-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflows related to translation updates #21
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Created by Mesar Hameed (@mhameed) | ||
|
||
name: Check that we dont have extended ascii or utf boms in our files | ||
|
||
on: | ||
pull_request: | ||
|
||
jobs: | ||
extendedAsciiAndBom: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
- name: check for files known to cause problems | ||
run: find . -type f | grep -vP "^./.git" | xargs file | grep -iP "bom|extended|iso" | ||
- name: | ||
if: failure() | ||
uses: unsplash/comment-on-pr@master | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
with: | ||
msg: "Please note that this pull request seems to contain files other than ascii or utf8 without bom." |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# https://crontab.guru/crontab.5.html | ||
|
||
name: Check for l10n updates | ||
|
||
on: | ||
|
||
workflow_dispatch: | ||
|
||
schedule: | ||
# * is a special character in YAML so you have to quote this string | ||
- cron: '1 * * * *' # Once every hour (minute 1) | ||
|
||
jobs: | ||
update-translations: | ||
runs-on: windows-latest | ||
steps: | ||
- name: Checkout main | ||
uses: actions/checkout@v2 | ||
|
||
- name: Push changes | ||
run: | | ||
git config --global user.name github-actions | ||
git config --global user.email [email protected] | ||
git remote add l10n https://github.com/nvdaaddons/addonName # Replace with the repo name, for example, clipContentsDesigner | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd be nice not to hardcode name of the repository. Have you tried playing with |
||
git fetch l10n | ||
git reset l10n/stable addon/doc addon/locale | ||
git commit -m "Update translations" | ||
git pull | ||
git push | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A new line here please. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is still not addressed though not very important obviously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placing this file in
.github/workflows
has an unfortunate side effect that this action would be run for addonTemplate repo which is not what we want. Perhaps these sample actions should be moved to something likeGitHubActions/sampleActions
and documented in the readme.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling this action for add-on template repository would work but only for this repo. If someone uses this template as is and their add-on is not registered in the translations system they would be getting failures by default. I still maintain that moving these files from
.github/workflows
and documenting each of these actions in the readme is the simplest way to deal with the problem though I don't have any authority over this repository obviously.