-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule for branch dash 0 #942
Conversation
...deleting branch `0v` and running `git branch -v` as the user intended
Nice idea, maybe it will be a good thing to make that more generic? To just replace any argument that starts with |
@nvbn When I quickly read your comment on my phone, I thought making this fix more generic sounded like a good idea, but upon reflection, I'm not so sure. In the specific case I coded up, the argument needs to turn into a flag. Would making that assumption more generic (i.e. convert all arguments starting with For that matter, what would the "undo" action look like, or would there even need to be an "undo" action? (In the specific example here, I need to delete a branch that was just accidentally created...what should the proper response be if |
@ProfessorTom you're right, initially I thought that I guess the only way to generalize this rule is to also support cases like |
Do you still want me to generalize this feature turning the Is there a case where this would cause more harm than good? |
bumping to get a review and hopefully a merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for contributing! Please mind my change requests including the correct naming of the test file test_get_branch_0v_to_dash_v.py
into test_git_branch_0v_to_dash_v.py
.
… matches in the future
Thank you for contributing, @ProfessorTom 👍 Please check a new PR, which is probably going to be #1212. |
Thank you for merging. |
fixes fat-fingering
git branch -0
instead ofgit branch -v