-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getch on windows #414
Fix getch on windows #414
Conversation
@@ -2,6 +2,8 @@ | |||
from warnings import warn | |||
from pprint import pformat | |||
import sys | |||
import win_unicode_console | |||
win_unicode_console.enable() #https://github.com/tartley/colorama/issues/32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the issue related here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you need to init win_unicode_console
before importing colorama
I've made a few changes, please check branch |
You moved |
@pakrym they said:
So Also I've updated code in branch |
I meant other part of it:
|
@pakrym ok, now it calls Is it work ok? |
Checked by myself, seems working. |
Fixes #378