storage/spanlatch: address minor PR comments

cockroachdb#31997 (review) Release note: None
nvanbenschoten · Dec 4, 2018 · af852f9 · af852f9
1 parent 60fa260
commit af852f9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/storage/spanlatch/manager.go b/pkg/storage/spanlatch/manager.go
@@ -259,7 +259,7 @@ func (m *Manager) insertLocked(lg *Guard) {
 			latches := lg.latches(s, a)
 			for i := range latches {
 				latch := &latches[i]
-				latch.id = m.nextID()
+				latch.id = m.nextIDLocked()
 				switch a {
 				case spanset.SpanReadOnly:
 					// Add reads to the readSet. They only need to enter
@@ -277,7 +277,7 @@ func (m *Manager) insertLocked(lg *Guard) {
 	}
 }
 
-func (m *Manager) nextID() uint64 {
+func (m *Manager) nextIDLocked() uint64 {
 	m.idAlloc++
 	return m.idAlloc
 }

diff --git a/pkg/storage/spanlatch/manager_test.go b/pkg/storage/spanlatch/manager_test.go
@@ -119,7 +119,7 @@ func TestLatchManager(t *testing.T) {
 	defer leaktest.AfterTest(t)()
 	var m Manager
 
-	// Try latch with no overlapping already-acquired lathes.
+	// Try latches with no overlapping already-acquired lathes.
 	lg1 := m.MustAcquire(spans("a", "", write), zeroTS)
 	m.Release(lg1)