Skip to content

Commit

Permalink
logictest: (speculatively) de-flake distsql_enum
Browse files Browse the repository at this point in the history
We opted this test out of using the span configs infra in cockroachdb#75281 after
observing a CI flake. Following the analysis in the last commit, it may
have been due to stale distsender caches affecting the physical plan
generated.

This fix is speculative because I was unable to repro the original flake
under stress. Attempt (successful after 1000s of runs on GCE worker over
20+ minutes):

    dev test pkg/sql/logictest \
    -f 'TestLogic/^5node-disk$/distsql_enum' \
    --show-logs -v --stress --stress-args '-p 4' -- --test_arg -show-sql

Release note: None
  • Loading branch information
irfansharif committed Jan 24, 2022
1 parent c538f2a commit 83f584d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/sql/logictest/testdata/logic_test/distsql_enum
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# LogicTest: 5node-default-configs !5node-metadata
# cluster-opt: disable-span-configs

# Regression test for nested tuple enum hydration (#74189)
statement ok
Expand Down Expand Up @@ -66,7 +65,7 @@ ALTER TABLE t2 INJECT STATISTICS '[
}
]'

query T nodeidx=1
query T nodeidx=1 retry
EXPLAIN (VEC)
SELECT x from t1 WHERE EXISTS (SELECT x FROM t2 WHERE t1.x=t2.x AND t2.y='hello')
----
Expand Down

0 comments on commit 83f584d

Please sign in to comment.