Skip to content

Commit

Permalink
util/interval: fix BenchmarkBTreeDeleteInsertCloneEachTime
Browse files Browse the repository at this point in the history
The benchmark was not using the subtest's `b.N`, so it was getting bogus
results. This confused cockroachdb#62212, which saw a regression from 0.000008611111111
nanoseconds to 0.0000101 nanoseconds.

With this fix, the benchmark no longer shows any movement over the past release.
  • Loading branch information
nvanbenschoten committed Mar 20, 2021
1 parent ee9f47b commit 3a6b152
Show file tree
Hide file tree
Showing 4 changed files with 128 additions and 60 deletions.
47 changes: 32 additions & 15 deletions pkg/kv/kvserver/concurrency/lockstate_interval_btree_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 32 additions & 15 deletions pkg/kv/kvserver/spanlatch/latch_interval_btree_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 3a6b152

Please sign in to comment.