Skip to content

Commit

Permalink
kv,storage,sql: purge snapshot isolation
Browse files Browse the repository at this point in the history
Snapshot isolation was disabled in v2.1, so it is safe to remove all
code paths that handle snapshot isolation in v2.2.

Note that the change to the MVCCMetadata checksum in
pkg/storage/below_raft_protos_test.go is safe, because the actual
encoding of the protobuf is not affected by this change. What is
affected is NewPopulatedMVCCMetadata, which no longer returns a TxnMeta
with a non-zero IsolationType, since the IsolationType field has been
removed.

This is a necessary precursor to cockroachdb#32487.

Release note: None
  • Loading branch information
benesch committed Dec 6, 2018
1 parent f0ac764 commit 39ba88b
Show file tree
Hide file tree
Showing 57 changed files with 1,028 additions and 1,961 deletions.
29 changes: 0 additions & 29 deletions c-deps/libroach/protos/roachpb/data.pb.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 0 additions & 21 deletions c-deps/libroach/protos/roachpb/data.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

50 changes: 4 additions & 46 deletions c-deps/libroach/protos/storage/engine/enginepb/mvcc3.pb.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 0 additions & 41 deletions c-deps/libroach/protos/storage/engine/enginepb/mvcc3.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 39ba88b

Please sign in to comment.