Skip to content

Commit

Permalink
storage/tscache: Pick up andy-kimball/arenaskl fix
Browse files Browse the repository at this point in the history
Fixes cockroachdb#31624.
Fixes cockroachdb#35557.

This commit picks up andy-kimball/arenaskl#4.

I strongly suspect that the uint32 overflow fixed in that PR was the
cause of the two index out of bounds panics. See that commit for more
details.

Release note: None
  • Loading branch information
nvanbenschoten committed Mar 12, 2019
1 parent 893e69f commit 2d35cc9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/storage/tscache/interval_skl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1218,10 +1218,10 @@ func BenchmarkIntervalSklAddAndLookup(b *testing.B) {
rng := rand.New(rand.NewSource(timeutil.Now().UnixNano()))

for n := 0; n < b.N/parallel; n++ {
readFrac := rng.Int31()
readFrac := rng.Int31n(10)
keyNum := rng.Int31n(max)

if (readFrac % 10) < int32(i) {
if readFrac < int32(i) {
key := []byte(fmt.Sprintf("%020d", keyNum))
s.LookupTimestamp(key)
} else {
Expand Down
2 changes: 1 addition & 1 deletion vendor

0 comments on commit 2d35cc9

Please sign in to comment.