-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update detours, ia2, sonic, w3c, wil #15695
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonarddeR
reviewed
Oct 27, 2023
Co-authored-by: Leonard de Ruijter <[email protected]>
Would it be possible to describe testing you have done some more? In particular:
|
See test results for failed build of commit ddb9ba40b9 |
michaelDCurran
previously approved these changes
Oct 30, 2023
See test results for failed build of commit 53173a1b5c |
See test results for failed build of commit 92d26ca0be |
michaelDCurran
requested changes
Oct 31, 2023
Co-authored-by: Michael Curran <[email protected]>
seanbudd
force-pushed
the
updateDependencies
branch
from
October 31, 2023 05:18
0c44824
to
ec90110
Compare
michaelDCurran
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Update various dependences to their latest commit on master.
Description of user facing changes
Should be none
Description of development approach
Updated detours, ia2, sonic, w3c, wil to their latest master commit.
Created a build to test.
Chrome tests were temporarily disabled due to an issue with Chrome on appveyor. This appears to be resolved after several successful builds with tests enabled, so they have been re-enabled.
Chrome tests were updated to support the latest w3c examples.
Testing strategy:
Known issues with pull request:
None
Code Review Checklist: