Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update detours, ia2, sonic, w3c, wil #15695

Merged
merged 13 commits into from
Oct 31, 2023
Merged

Update detours, ia2, sonic, w3c, wil #15695

merged 13 commits into from
Oct 31, 2023

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Oct 27, 2023

Link to issue number:

None

Summary of the issue:

Update various dependences to their latest commit on master.

Description of user facing changes

Should be none

Description of development approach

Updated detours, ia2, sonic, w3c, wil to their latest master commit.

Created a build to test.

Chrome tests were temporarily disabled due to an issue with Chrome on appveyor. This appears to be resolved after several successful builds with tests enabled, so they have been re-enabled.
Chrome tests were updated to support the latest w3c examples.

Testing strategy:

  • General smoke testing for ia2 and wil changes
  • Chrome tests passing for w3c changes
  • Tested rate boost on espeak for sonic changes
  • Test the display model on the file properties dialog using these steps for detours changes

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd marked this pull request as ready for review October 27, 2023 05:02
@seanbudd seanbudd requested a review from a team as a code owner October 27, 2023 05:02
@lukaszgo1
Copy link
Contributor

Would it be possible to describe testing you have done some more? In particular:

  • Have you verified that display model works by following our testing steps
  • Are our Chrome system tests compatible with the new version of ARIA practices? As an aside is there any plan for reenabling these on AppVeyor?

@seanbudd seanbudd marked this pull request as draft October 30, 2023 04:25
@AppVeyorBot
Copy link

See test results for failed build of commit ddb9ba40b9

michaelDCurran
michaelDCurran previously approved these changes Oct 30, 2023
@AppVeyorBot
Copy link

See test results for failed build of commit 53173a1b5c

@AppVeyorBot
Copy link

See test results for failed build of commit 92d26ca0be

@seanbudd seanbudd marked this pull request as ready for review October 31, 2023 03:27
@seanbudd seanbudd requested a review from a team as a code owner October 31, 2023 03:27
include/readme.md Outdated Show resolved Hide resolved
include/readme.md Outdated Show resolved Hide resolved
seanbudd and others added 2 commits October 31, 2023 16:17
Co-authored-by: Michael Curran <[email protected]>
@seanbudd seanbudd merged commit da446b3 into master Oct 31, 2023
@seanbudd seanbudd deleted the updateDependencies branch October 31, 2023 06:20
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants