Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest next snapshot triggers an error when trying to read merged cells in Excel 2007 #6889

Closed
sukiletxe opened this issue Feb 15, 2017 · 4 comments
Assignees
Milestone

Comments

@sukiletxe
Copy link

Steps:

  1. Merge two or more cells in Excel 2007.
  2. Move around and focus the cell.

Expected: NVDA reads the cell's contents.
Acttual: NVDA triggers an error.
Log:

IO - inputCore.InputManager.executeGesture (00:54:17):
Input: kb(laptop):upArrow
ERROR - eventHandler.executeEvent (00:54:17):
error executing event: gainFocus on <NVDAObjects.window.excel.ExcelMergedCell object at 0x0593D090> with extra args of {}
Traceback (most recent call last):
  File "eventHandler.pyc", line 143, in executeEvent
  File "eventHandler.pyc", line 91, in __init__
  File "eventHandler.pyc", line 98, in next
  File "C:\Users\sukil etxenike\AppData\Roaming\nvda\addons\remote\globalPlugins\remoteClient\__init__.py", line 341, in event_gainFocus
  File "eventHandler.pyc", line 98, in next
  File "NVDAObjects\__init__.pyc", line 893, in event_gainFocus
  File "NVDAObjects\window\excel.pyc", line 1405, in reportFocus
  File "textInfos\offsets.pyc", line 398, in getTextWithFields
  File "NVDAObjects\window\excel.pyc", line 992, in _getFormatFieldAndOffsets
  File "comtypesMonkeyPatches.pyc", line 37, in new__getattr__
  File "comtypes\client\dynamic.pyc", line 93, in __getattr__
  File "comtypes\automation.pyc", line 643, in GetIDsOfNames
COMError: (-2147352570, 'Nombre desconocido.', (None, None, None, 0, None))

Latest stable works.

"Nombre desconocido" = "Unknown name"

@sukiletxe
Copy link
Author

If I disable the announcement of cell borders, the bug is no longer present. Also, NVDA + Tab always works.

@jcsteh
Copy link
Contributor

jcsteh commented Feb 17, 2017

This sounds like it might be a regression introduced by #3044. @feerrenrut, would you mind investigating?

feerrenrut added a commit that referenced this issue Feb 17, 2017
Fixes #6889
The `DisplayFormat` property does not exist on ranges for excel 2007.
Instead (if the call to DisplayFormat fails) the borders property is
accessed directly on the range object rather than through the `DisplayFormat`
@feerrenrut
Copy link
Contributor

This issue seems to effect excel 2007, and not excel 2013.

The relevant difference in the API is the DisplayFormat property that exists in excel 2013 but not in excel 2007. If the call to DisplayFormat fails instead we access the borders via the range.borders property.

feerrenrut added a commit that referenced this issue Feb 17, 2017
Fixes #6889
The `DisplayFormat` property does not exist on ranges for excel 2007.
Instead (if the call to DisplayFormat fails) the borders property is
accessed directly on the range object rather than through the `DisplayFormat`
feerrenrut added a commit that referenced this issue Feb 17, 2017
Fixes #6889
The `DisplayFormat` property does not exist on ranges for excel 2007.
Instead (if the call to DisplayFormat fails) the borders property is
accessed directly on the range object rather than through the `DisplayFormat`
feerrenrut added a commit that referenced this issue Feb 17, 2017
Fixes #6889
The `DisplayFormat` property does not exist on ranges for excel 2007.
Instead (if the call to DisplayFormat fails) the borders property is
accessed directly on the range object rather than through the `DisplayFormat`
feerrenrut added a commit that referenced this issue Feb 20, 2017
Fixes #6889 and #3044
Merge branch 'i6889-fixExcelMergedCellRegression' into next
feerrenrut added a commit that referenced this issue Feb 20, 2017
Fixes #6889 and #3044
Merge branch 'i6889-fixExcelMergedCellRegression' into next
@feerrenrut
Copy link
Contributor

Closing this issue since this regression on next has been resolved. See #6895 and #3044

@nvaccessAuto nvaccessAuto added this to the 2017.2 milestone Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants