revue cursor: strange behavior in windows-terminal with braille #11288
Labels
app/windows-terminal
New terminal app, potentially supersedes app/windows-console (repo: microsoft/terminal)
close/worksforme
component/braille
Comments
|
This could very possibly be caused by microsoft/terminal#7342 as I think Braille also relies on |
feerrenrut
added
app/windows-terminal
|
After further investigation, this is almost definitely due to microsoft/terminal#7342 (comment). |
ghost
pushed a commit
to microsoft/terminal
that referenced
this issue
Sep 4, 2020
Conhost expands UIA text ranges when moved. This means that degenerate ranges become non-degenerate after movement, leading to odd behaviour from UIA clients. This PR doesn't expand degenerate ranges, but rather keeps them degenerate by moving `_end` to the newly-changed `_start`. Tested in the NVDA Python console (cases with `setEndPoint` and `compareEndPoints` described in #7342). Also ran the logic by @michaelDCurran. Closes #7342 Almost definitely addresses nvaccess/nvda#11288 (although I'll need to test with my Braille display). Also fixes an issue privately reported to me by @Simon818 with copy/paste from review cursor which originally lead me to believe the issue was with `moveEndPointByRange`.
|
I can confirm that microsoft/terminal#7530 fixes this issue. |
|
Could this issue please be closed? |
|
Thanks Bill for the contribution. I am closing this issue as fixed. |
DHowett
pushed a commit
to microsoft/terminal
that referenced
this issue
Sep 18, 2020
Conhost expands UIA text ranges when moved. This means that degenerate ranges become non-degenerate after movement, leading to odd behaviour from UIA clients. This PR doesn't expand degenerate ranges, but rather keeps them degenerate by moving `_end` to the newly-changed `_start`. Tested in the NVDA Python console (cases with `setEndPoint` and `compareEndPoints` described in #7342). Also ran the logic by @michaelDCurran. Closes #7342 Almost definitely addresses nvaccess/nvda#11288 (although I'll need to test with my Braille display). Also fixes an issue privately reported to me by @Simon818 with copy/paste from review cursor which originally lead me to believe the issue was with `moveEndPointByRange`. (cherry picked from commit 7a03f75)
donno2048
added a commit
to donno2048/terminal
that referenced
this issue
Sep 28, 2020
Conhost expands UIA text ranges when moved. This means that degenerate ranges become non-degenerate after movement, leading to odd behaviour from UIA clients. This PR doesn't expand degenerate ranges, but rather keeps them degenerate by moving `_end` to the newly-changed `_start`. Tested in the NVDA Python console (cases with `setEndPoint` and `compareEndPoints` described in #7342). Also ran the logic by @michaelDCurran. Closes #7342 Almost definitely addresses nvaccess/nvda#11288 (although I'll need to test with my Braille display). Also fixes an issue privately reported to me by @Simon818 with copy/paste from review cursor which originally lead me to believe the issue was with `moveEndPointByRange`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
Actual behavior:
whole line underlined by dots 7, 8
Expected behavior:
only the first cell is underlined by dots 7, 8
System configuration
NVDA installed/portable/running from source:
installed
NVDA version:
2020.2beta1
Windows version:
Windows 10Ver2004 (64-бит) build 19041.330
Name and version of other software in use when reproducing the issue:
Windows Terminal Preview 1.1.1671.0
Other questions
Does the issue still occur after restarting your computer?
yep
Have you tried any other versions of NVDA? If so, please report their behaviors.
not applicable because 2020.2 is first version wich properly supports windows terminal
If addons are disabled, is your problem still occuring?
yep
Did you try to run the COM registry fixing tool in NVDA menu / tools?
yep. but i think this is not applicable too.
FYI: @codeofdusk
The text was updated successfully, but these errors were encountered: