Skip to content

Commit

Permalink
Report the update of the selection when using Word selection extend /…
Browse files Browse the repository at this point in the history
… reduce commmands (`f8` or `shift+f8`) (#17424)

Partially fixes #3293.

Summary of the issue:
When using f8 (extend selection) or shift+f8 (reduce selection) in Word, the selection changes are not reported.

Description of user facing changes
When using f8 (extend selection) or shift+f8 (reduce selection) in Word, the selection changes will now be reported.
If the selection is extended / reduced at both ends, two consecutive selection update messages are reported, as done for control+a (select all).

Description of development approach
In WordDocument.initOverlayClass, bind script_caret_changeSelection to f8 and shift+f8, as already done for other gestures such as alt+shift+home or alt+shift+pageDown.
  • Loading branch information
CyrilleB79 authored Nov 26, 2024
1 parent c32e0e7 commit 5d81cd2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions source/NVDAObjects/window/winword.py
Original file line number Diff line number Diff line change
Expand Up @@ -1975,6 +1975,8 @@ def initOverlayClass(self):
self.bindGesture("kb:alt+shift+end", "caret_changeSelection")
self.bindGesture("kb:alt+shift+pageUp", "caret_changeSelection")
self.bindGesture("kb:alt+shift+pageDown", "caret_changeSelection")
self.bindGesture("kb:f8", "caret_changeSelection")
self.bindGesture("kb:shift+f8", "caret_changeSelection")

__gestures = {
"kb:control+pageUp": "caret_moveByLine",
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ To use this feature, "allow NVDA to control the volume of other applications" mu
* When toggling double underline in LibreOffice Writer using the corresponding keyboard shortcut, NVDA announces the new state ("double underline on"/"double underline off"). (#6915, @michaelweghorn)
* Automatic language switching is now supported when using Microsoft Speech API version 5 (SAPI5) and Microsoft Speech Platform voices. (#17146, @gexgd0419)
* NVDA can now be configured to speak the current line or paragraph when navigating with braille navigation keys. (#17053, @nvdaes)
* In Word, the selection update is now reported when using Word commands to extend or reduce the selection (`f8` or `shift+f8`). (#3293, @CyrilleB79)

### Changes

Expand Down

0 comments on commit 5d81cd2

Please sign in to comment.