-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix log parsing undefined variable and duplicate sequence id errors #1809
Merged
rapids-bot
merged 12 commits into
nv-morpheus:branch-24.10
from
dagardner-nv:david-log-parsing-undefined-var
Jul 25, 2024
Merged
Fix log parsing undefined variable and duplicate sequence id errors #1809
rapids-bot
merged 12 commits into
nv-morpheus:branch-24.10
from
dagardner-nv:david-log-parsing-undefined-var
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h, and truncation is False, leading to duplicate sequence id's
…nger than the sequence length, prevents building a seq_ids tensor with duplicate values
…the if-statement branch followed
mdemoret-nv
approved these changes
Jul 24, 2024
/merge |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two related bugs which occur when running the
log_parsing
example with unexpected data.Fix error in
LogParsingPostProcessingStage::__get_label_dicts
where there is a possibility that thenew_label
andnew_confidence
variables are undefined.Fix error where the
tokenize_text_series
method can return a sequence_ids list with duplicate ids when a text series is passed in and one of the values has a length longer thanseq_len
andtruncation=False
, this prevents a down-stream error in the inference stageNot sure if this is the best place to catch this error.
Closes #1765
By Submitting this PR I confirm: