-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring changes #581
Merged
Merged
Refactoring changes #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l other Legion references
magnatelee
added
the
category:improvement
PR introduces an improvement and will be classified as such in release notes
label
Feb 18, 2023
manopapad
approved these changes
Feb 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One trivial comment, otherwise looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:improvement
PR introduces an improvement and will be classified as such in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some loose ends in the C++ API that accidentally exposed Legion names directly to client libraries. This would be confusing to developers, as they might think they need to learn two APIs, even though they would, and should, only need to use a small fraction of the Legion API in Legate in most cases. This PR makes the following refactoring changes to hide Legion references from the Legate API so developers can learn only one API for Legate:
The PR also simplifies and hides all the implementation detail of task variant registration as a bonus point.