Resolve numpy 1.25 issues #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manopapad
added
the
category:bug-fix
manopapad
approved these changes
Jun 21, 2023
bryevdv
commented
Jun 21, 2023
cunumeric/module.py
Outdated
| @@ -663,7 +663,7 @@ def arange( | |||
| step = 1 | |||
|
|
|||
| if dtype is None: | |||
| dtype = np.find_common_type([], [type(start), type(stop), type(step)]) | |||
| dtype = np.result_type(type(start), type(stop), type(step)) | |||
There was a problem hiding this comment.
@seberg is this OK or do we need to pass actual scalars?
There was a problem hiding this comment.
find_common_type calls np.dtype() first while np.result_type tends to convert to arrays when it doens't see an exact scalar type or dtype. I think that could fail with the type() for very strange input.
So it should be a bit safer to pass the values (or use np.dtype(type(start)) to keep the identical behavior).
Passing values may also be more future-proof, but that goes into too much arange weirdness.
manopapad
reviewed
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an abridged version of #972 to clear up CI issues, that updates everything except a few more complicated uses of
find_common_types.A
test_argsort.pytest is failing for me locally, but also fails for me locally onbranch-23.07so I don't think it is related.