Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in random integer functions #966

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Fix bugs in random integer functions #966

merged 3 commits into from
Jun 13, 2023

Conversation

manopapad
Copy link
Contributor

Fix bugs reported on #955 and #965:

  • cunumeric.random.randint high limit is inclusive when running in eager mode
  • when size is None should be returning a scalar, not a singleton array
  • missing low and high type checks and limit checks

@manopapad manopapad added the category:bug-fix PR is a bug fix and will be classified as such in release notes label Jun 9, 2023
@manopapad manopapad requested a review from bryevdv June 9, 2023 20:51
@manopapad manopapad mentioned this pull request Jun 9, 2023
Merged
@manopapad manopapad merged commit e510d05 into nv-legate:branch-23.07 Jun 13, 2023
@manopapad manopapad deleted the randint-bugs branch July 19, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryevdv bryevdv bryevdv approved these changes

Assignees
No one assigned
Labels
category:bug-fix PR is a bug fix and will be classified as such in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manopapad @bryevdv