Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back to NumPy eagerly on RandomState methods #959

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fall back to NumPy eagerly on RandomState methods #959

merged 1 commit into from
Jun 8, 2023

Conversation

manopapad
Copy link
Contributor

Extends the fix for #798 to also cover np.random.RandomState. This should allow code like the following to not take forever:

indices = cn.arange(100000)
generator = cn.random.RandomState(42)
generator.shuffle(indices)

CC @betatim

@manopapad manopapad added the category:bug-fix PR is a bug fix and will be classified as such in release notes label Jun 7, 2023
@manopapad manopapad requested a review from bryevdv June 7, 2023 21:11
@manopapad manopapad merged commit eb473bd into nv-legate:branch-23.07 Jun 8, 2023
@manopapad manopapad deleted the random-state-fallback branch July 19, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryevdv bryevdv bryevdv approved these changes

Assignees
No one assigned
Labels
category:bug-fix PR is a bug fix and will be classified as such in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manopapad @bryevdv