Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #531 case 1-3
Case 1 & 2:
Cause:
cuNumeric tries to create an ndarray with the shape of
(ceil((stop - start)/step),)
and when the value is negative we hit error from NumPy stating negative dimensions are not being allowed.Fix:
Create empty array when the ceil is negative.
Case 3:
Cause:
cuNumeric current uses
stop
solely to determine out dtype and when stop is integer while the other two consist floating points there would be a precision loss.Fix:
Infer dtype from all three arguments.