Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving performance for some special cases of advanced indexing #731

Merged
merged 8 commits into from
Dec 27, 2022
Merged

Improving performance for some special cases of advanced indexing #731

merged 8 commits into from
Dec 27, 2022

Conversation

ipdemes
Copy link
Contributor

@ipdemes ipdemes commented Dec 6, 2022

This PR should improve performance for the case of a[tuple_of_indices]=scalar where tuple of indices contains single ndarray of boolean type.
In this case original array a will be transformed so that putmask or ADVANCED_INDEXING_TASK can be called to avoid Realm Copy operation.

@ipdemes ipdemes added the category:improvement PR introduces an improvement and will be classified as such in release notes label Dec 6, 2022
@ipdemes ipdemes self-assigned this Dec 6, 2022
manopapad
manopapad reviewed Dec 16, 2022
View reviewed changes
cunumeric/deferred.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Dec 16, 2022
View reviewed changes
cunumeric/deferred.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Dec 16, 2022
View reviewed changes
cunumeric/deferred.py Outdated Show resolved Hide resolved
manopapad
manopapad approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@manopapad manopapad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I merged from branch-22.12, which should hopefully make CI succeed.

@ipdemes
Copy link
Contributor Author

ipdemes commented Dec 21, 2022

@manopapad : some tests still fail.

@ipdemes
Copy link
Contributor Author

ipdemes commented Dec 21, 2022

For example the one in test_einsum :

TypeError: can't convert complex to float

did something change in this test on in the way we convert types?

@manopapad
Copy link
Contributor

The CI failure is due to the recent update of NumPy to 1.24 in our CI images. #745 should fix them. You can go ahead and merge your changes, since they're not related to these failures.

@ipdemes ipdemes merged commit a2bc300 into nv-legate:branch-22.12 Dec 27, 2022
@ipdemes ipdemes deleted the ai_bool_special_case branch January 12, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manopapad manopapad manopapad approved these changes

Assignees

@ipdemes ipdemes

Labels
category:improvement PR introduces an improvement and will be classified as such in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipdemes @manopapad