-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests utils to make --directory work correctly. #592
Conversation
@robinw0928 Your changes have broken the handling of cunumeric/tests/_utils/__init__.py Lines 64 to 69 in bf3e6da
There are four failing tests, exactly these four, that should not be run at all. You will need to update your changes to make sure that the cunumeric/tests/_utils/config.py Lines 103 to 107 in bf3e6da
Also, FYI I wrote tests for the test driver itself:
They aren't yet run in CI. I plan to figure out how to add them to CI when the test driver code moves down to |
Thanks @bryevdv |
@robinw0928 can you look in to installing the |
@robinw0928 The now unused
|
Currently, when cwd is not cunumeric dir where test.py is located, if we use default root_dir or specify the directory, no test files would be found and zero division error is reported in summary.
In this change, we do two enhancements: