fix error print in test_unary_ufunc #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinz
added
category:bug-fix
marcinz
reviewed
Aug 31, 2022
| print(arr) | ||
| print(f"dtype: {arr.dtype}") | ||
| print("Input:") | ||
| print(in_np) |
There was a problem hiding this comment.
So now in_np is always just one array or a scalar?
There was a problem hiding this comment.
Correct, all the test cases were a single input (unary functions) so I just simplified this to be just one array.
marcinz
approved these changes
Sep 1, 2022
|
Strange that we got a failure on einsum. |
|
Should we merge this now @jjwilke? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes to the tests broke error printing when errors occur due to a change in
in_np. This fixes the error printing.