Ensure test.py --use flag fully overrides USE_* envvars #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess I thought they were supposed to combine. LGTM but there is probably a test here that needs to be updated: https://github.com/nv-legate/cunumeric/blob/branch-22.10/tests/_utils/tests/test_config.py Those test files are runnable with standard pytest |
sbak5
pushed a commit
to sbak5/cunumeric
that referenced
this pull request
Aug 17, 2022
* Ensure test.py --use flag fully overrides USE_* envvars * Update a test-tools unit test Co-authored-by: Manolis Papadakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.