-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cunumeric.ndim
#495
cunumeric.ndim
#495
Conversation
Does this work:
|
I think so |
a_np = np.array(a) | ||
|
||
assert np.ndim(a_np) == num.ndim(a) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also check a few non-ndarray values? e.g.
42
[0,1,2]
[[0,1,2],[3,4,5]]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Also updated the docs for ndim, and had to add some unrelated missing functions to fix the doc build.
One remaining comment above, to add a couple more cases to the tests.
* Add cunumeric.ndim * Add Avail. info to ndim, add to docs and API comparison table * Add some missing function references to docs * Test cases passing Python values to cunumeric.ndim Co-authored-by: Manolis Papadakis <[email protected]>
Fixes #494