-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for array shape () passed as an index argument in advanced indexing #486
Conversation
This has different behavior from NumPy on This code prints out
while NumPy returns
I naively just tried removing the changes on deferred.py (and keeping just the C++ changes), but that triggers nv-legate/legate#314. |
@manopapad : Thank you for finding this! I will wait for Wonchan to update on #314 |
@manopapad I have added fixes for few other cases when either lhs or rhs are futures |
@manopapad @magnatelee : do you think we can still merge this to 22.07 since if fixes some corner cases of advanced indexing? Or should I change this PR to be merged to 22.10? |
I added some further tests involving set/getitem on scalar arrays. It looks like there are issues when the index or value array is 0d and backed by a region-field:
This example asserts inside of Legion:
This might require changes in the core. |
@manopapad I have reproduced the error and it seems it might take some time to fix it. Should we create a separate GitHub issue and PR for this use case? |
Yes, let me update the testcase to skip the problematic cases, and I'll open a new issue about this. |
@manopapad : do you think we can merge it when CI pass? |
…nced indexing (nv-legate#486) * fxing logic for some advanced_indexing test cases * Reformatting of new testcases by @bryevdv * Add new required test packages to conda env files Co-authored-by: Manolis Papadakis <[email protected]>
This PR making following work: