towards addressing issue 472 #477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
reviewed
Jul 28, 2022
| @@ -823,6 +823,21 @@ def __ge__(self, rhs): | |||
|
|
|||
| def _convert_key(self, key, first=True): | |||
| # Convert any arrays stored in a key to a cuNumeric array | |||
| if isinstance(key, slice): | |||
| if isinstance(key.start, ndarray): | |||
There was a problem hiding this comment.
I'd suggest you do the integer conversion unconditionally. An isinstance call isn't particularly cheaper. Plus the code would look cleaner in that way.
|
I have another attempt at this, using the |
|
closing this PR as #479 addresses the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #472
I am not sure if this is the best solution because it will inline_map bounds of the slice. @wonchan, @manopapad : do you suggest any better idea?