Adding support for take_along_axis and put_along_axis #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
reviewed
Jul 1, 2022
bryevdv
reviewed
Jul 1, 2022
bryevdv
reviewed
Jul 1, 2022
bryevdv
reviewed
Jul 1, 2022
bryevdv
reviewed
Jul 1, 2022
bryevdv
reviewed
Jul 5, 2022
manopapad
reviewed
Jul 27, 2022
manopapad
reviewed
Jul 27, 2022
manopapad
reviewed
Jul 27, 2022
manopapad
reviewed
Jul 27, 2022
manopapad
reviewed
Jul 27, 2022
manopapad
reviewed
Jul 27, 2022
manopapad
reviewed
Jul 27, 2022
manopapad
reviewed
Jul 27, 2022
manopapad
reviewed
Jul 27, 2022
manopapad
reviewed
Jul 30, 2022
cunumeric/module.py
Outdated
| axis : int | ||
| The axis to take 1d slices along. If axis is None, the destination | ||
| array is treated as if a flattened 1d view had been created of it. | ||
| `axis=None` case is currenlty supported only for 1D input arrays. |
manopapad
reviewed
Jul 30, 2022
cunumeric/module.py
Outdated
| a.shape, computed_axis, indices | ||
| ) | ||
| a[ind] = values | ||
| return |
There was a problem hiding this comment.
No need for a return statement here
manopapad
reviewed
Jul 30, 2022
cunumeric/module.py
Outdated
| @@ -2545,7 +2545,8 @@ def take_along_axis(a: ndarray, indices: ndarray, axis: int) -> ndarray: | |||
| Returns | |||
| ------- | |||
| out: ndarray (Ni..., J, Nk...) | |||
| The indexed result. | |||
| The indexed result. It is going to be a vew to `arr` for most cases, | |||
manopapad
approved these changes
Jul 30, 2022
sbak5
pushed a commit
to sbak5/cunumeric
that referenced
this pull request
Aug 17, 2022
adding support for take_along_axis and put_along_axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.