Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_floating.py test to call sys.exit #433

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Fix test_floating.py test to call sys.exit #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df629d7
Added a missing sys.exit
marcinz Jun 29, 2022
3738585
Brian's patch to fix the problem
marcinz Jun 29, 2022
693af70
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cunumeric/_ufunc/ufunc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,10 @@ def _maybe_convert_output_to_cunumeric_ndarray(
raise TypeError("return arrays must be of ArrayType")

def _prepare_operands(
self, *args: Any, out: Union[ndarray, None], where: bool = True
self,
*args: Any,
out: Union[ndarray, tuple[ndarray, ...], None],
where: bool = True,
) -> tuple[
Sequence[ndarray],
Sequence[Union[ndarray, None]],
Expand Down Expand Up @@ -295,6 +298,8 @@ def _prepare_operands(
computed_out = (None,) * self.nout
elif not isinstance(out, tuple):
computed_out = (out,)
else:
computed_out = out

outputs = tuple(
self._maybe_convert_output_to_cunumeric_ndarray(arr)
Expand Down Expand Up @@ -469,7 +474,7 @@ def _resolve_dtype(
def __call__(
self,
*args: Any,
out: Union[ndarray, None] = None,
out: Union[ndarray, tuple[ndarray, ...], None] = None,
where: bool = True,
casting: CastingKind = "same_kind",
order: str = "K",
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_floating.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,4 @@ def test_typing_unary(fun, dtype, shape):
if __name__ == "__main__":
import sys

pytest.main(sys.argv)
sys.exit(pytest.main(sys.argv))