Use Numpy axis normalizations where possible #419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues: fixes #412
@magnatelee I think this is smaller in scope than you have imagined, but I am not sure much more is advised. Some notes:
array.py
,sort.py
,linalg.py
I have applied the Numpy normalization functions in places where it seemed to make sense. Most locations were just passing values other functions.
fft.py
Most locations just do
computed_axis = (axis,) if axis is not None else None
which does not seem worth defining a new function for. One place calls a_sanitize_user_axes
but that function does unique conversion that takes shape into account.deferred.py
A few uses here, but handles comepletely differently, e.g. via
result.project
ufunc.py
,eager.py
The few uses here just pass on to other functions
thunk.py
no code, just signatures