adding bounds check for advanced indexing

[ipdemes]

addressing issue #31

[magnatelee]

@ipdemes is this a complete PR? I don't see any changes on the Python side to make the exceptions re-raised.

[ipdemes]

@ipdemes is this a complete PR? I don't see any changes on the Python side to make the exceptions re-raised.

That is right, I didn't push changes to the python code

[manopapad]

I think we should throw the standard Python IndexError exception here, as NumPy does. We don't need a custom CuNumericError in this case.

>>> import numpy as np
>>> x = np.ones((4,))
>>> x[[0,1,2,3,4]]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
IndexError: index 4 is out of bounds for axis 0 with size 4

[ipdemes]

@manopapad makes sense. Will change this

[magnatelee]

the variable name dim is very confusing. I believe you meant extent, right? dim seems synonymous with axis in other contexts, so let's change this.

[magnatelee]

I'd actually rewrite this function to something like this:

coord_t sanitized_index = index < 0 ? index + dim : index;
if (sanitized_index < 0 || sanitized_index >= extent) throw ...
return sanitized_index;

[magnatelee]

@ipdemes merge this with the latest branch-22.07, then you won't see the failure on 2 GPUs anymore.

[ipdemes]

@ipdemes merge this with the latest branch-22.07, then you won't see the failure on 2 GPUs anymore.

done