Add support for using cupy in sort.py #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robinwnv
commented
Jun 13, 2022
robinwnv
commented
- Add option to specify using legate, cupy or numpy
- Add option to specify which memory pool to use for cupy
- Define time methods for cupy
1. Add option to specify using legate, cupy or numpy 2. Add option to specify which memory pool to use for cupy 3. Define time methods for cupy
for more information, see https://pre-commit.ci
manopapad
reviewed
Jun 14, 2022
manopapad
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
One minor question, otherwise LGTM. Maybe @mfoerste4 should take a look as well?
|
LGTM as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.