Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc small updates #352

Merged
merged 4 commits into from
May 13, 2022
Merged

Misc small updates #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5eb4ca8
add missing annotations
bryevdv May 13, 2022
7b3f57b
remove old conda env file
bryevdv May 13, 2022
fc5e8e3
specify min mypy version
bryevdv May 13, 2022
d6edd57
update README
bryevdv May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ cuNumeric requires the following:
- GNU Make
- C++17 compatible compiler (g++, clang, or nvc++)
- Fortran compiler (for building OpenBLAS; not necessary if you provide a pre-built version of OpenBLAS)
- the Python packages listed in `conda/cunumeric_dev.yml`
- the Python packages listed in any one of the conda environment files:
- `conda/environment-test-3.8.yml`
- `conda/environment-test-3.9.yml`
- `conda/environment-test-3.10.yml`

See the [corresponding section](https://github.com/nv-legate/legate.core#dependencies)
on the Legate Core instructions for help on installing the required Python packages
Expand Down
26 changes: 0 additions & 26 deletions conda/cunumeric_dev.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion conda/environment-test-3.10.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dependencies:
- clang-tools>=8
- coverage
- mock
- mypy
- mypy>=0.942
- pre-commit
- pynvml
- pytest
Expand Down
2 changes: 1 addition & 1 deletion conda/environment-test-3.8.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dependencies:
- clang-tools>=8
- coverage
- mock
- mypy
- mypy>=0.942
- pre-commit
- pynvml
- pytest
Expand Down
2 changes: 1 addition & 1 deletion conda/environment-test-3.9.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dependencies:
- clang-tools>=8
- coverage
- mock
- mypy
- mypy>=0.942
- pre-commit
- pynvml
- pytest
Expand Down
6 changes: 3 additions & 3 deletions cunumeric/coverage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,13 +257,13 @@ def decorator(cls: type) -> type:
return decorator


def is_implemented(obj):
def is_implemented(obj: Any) -> bool:
return hasattr(obj, "_cunumeric") and obj._cunumeric.implemented


def is_single(obj):
def is_single(obj: Any) -> bool:
return hasattr(obj, "_cunumeric") and obj._cunumeric.single


def is_multi(obj):
def is_multi(obj: Any) -> bool:
return hasattr(obj, "_cunumeric") and obj._cunumeric.multi